History

Fix potential XSS vulnerability in rename hint

The file name displayed in the rename hint should be escaped to avoid XSS. Note that this vulnerability is only applicable when an attacker has gained push access to the repository.

Lukas Fleischer committed 15 years ago

Commit bebe89d1 parent 1e25ac51 file · +6 −4Browse files

Unified · Split

ui-diff.c+6−4
@@ -97,10 +97,12 @@ static void print_fileinfo(struct fileinfo *info) · 96 unmodified lines
9797 htmlf("</td><td class='%s'>", class);
9898 cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1,
9999 ctx.qry.sha2, info->new_path, 0);
100− if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED)
101− htmlf(" (%s from %s)",
102− info->status == DIFF_STATUS_COPIED ? "copied" : "renamed",
103− info->old_path);
100+ if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) {
101+ htmlf(" (%s from ",
102+ info->status == DIFF_STATUS_COPIED ? "copied" : "renamed");
103+ html_txt(info->old_path);
104+ html(")");
105+ }
104106 html("</td><td class='right'>");
105107 if (info->binary) {
106108 htmlf("bin</td><td class='graph'>%ld -> %ld bytes",

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t