import { describe, expect, it } from "@effect/vitest";import { Effect, Predicate } from "effect";import { HttpServerResponse } from "effect/unstable/http"; import type { OAuthClientProvider } from "@modelcontextprotocol/sdk/client/auth.js";import { StreamableHTTPError } from "@modelcontextprotocol/sdk/client/streamableHttp.js";import { McpError } from "@modelcontextprotocol/sdk/types.js";import { ElicitationResponse } from "@executor-js/sdk";import { serveTestHttpApp } from "@executor-js/sdk/testing"; import { createMcpConnector, type McpConnection, type McpConnector } from "./connection";import { McpInvocationError, McpOAuthReauthorizationRequired } from "./errors";import { invokeMcpTool } from "./invoke"; const acceptAll = () => Effect.succeed(ElicitationResponse.make({ action: "accept" })); const rejectingConnector = (cause: unknown): McpConnector => Effect.succeed({ // oxlint-disable-next-line executor/no-double-cast -- boundary: minimal fake MCP client implements only the methods invokeMcpTool calls client: { setRequestHandler: () => undefined, // oxlint-disable-next-line executor/no-promise-reject -- boundary: fake MCP client rejects to exercise invocation error wrapping callTool: () => Promise.reject(cause), } as unknown as McpConnection["client"], close: () => Promise.resolve(), }); const reauthorizationProvider: OAuthClientProvider = { get redirectUrl() { return "http://localhost/oauth/callback"; }, get clientMetadata() { return { redirect_uris: ["http://localhost/oauth/callback"], grant_types: ["authorization_code", "refresh_token"] as string[], response_types: ["code"] as string[], token_endpoint_auth_method: "none" as const, client_name: "Executor", }; }, clientInformation: () => ({ client_id: "test-client" }), saveClientInformation: () => undefined, tokens: () => ({ access_token: "expired-token", token_type: "Bearer" }), saveTokens: () => undefined, redirectToAuthorization: async () => { // oxlint-disable-next-line executor/no-try-catch-or-throw -- boundary: MCP SDK OAuthClientProvider callback can only signal reauthorization by throwing throw new McpOAuthReauthorizationRequired({ message: "reauthorization required" }); }, saveCodeVerifier: () => undefined, codeVerifier: () => "unused", saveDiscoveryState: () => undefined, discoveryState: () => undefined,}; const serveReauthorizationChallengeServer = () => serveTestHttpApp((request) => Effect.sync(() => { const origin = `http://${request.headers.host ?? "127.0.0.1"}`; const requestUrl = new URL(request.url, origin); if (requestUrl.pathname.startsWith("/.well-known/oauth-protected-resource")) { return HttpServerResponse.jsonUnsafe({ resource: `${origin}/mcp`, authorization_servers: [origin], bearer_methods_supported: ["header"], scopes_supported: ["read"], }); } if ( requestUrl.pathname === "/.well-known/oauth-authorization-server" || requestUrl.pathname === "/.well-known/openid-configuration" ) { return HttpServerResponse.jsonUnsafe({ issuer: origin, authorization_endpoint: `${origin}/authorize`, token_endpoint: `${origin}/token`, response_types_supported: ["code"], grant_types_supported: ["authorization_code", "refresh_token"], code_challenge_methods_supported: ["S256"], token_endpoint_auth_methods_supported: ["none"], scopes_supported: ["read"], }); } if (requestUrl.pathname === "/mcp" && request.method === "GET") { return HttpServerResponse.text("SSE disabled", { status: 405 }); } return HttpServerResponse.jsonUnsafe( { error: "invalid_token" }, { status: 401, headers: { "www-authenticate": `Bearer resource_metadata="${origin}/.well-known/oauth-protected-resource/mcp", error="invalid_token"`, }, }, ); }), ); // The status-extraction cases share one shape: dial a connector that rejects// with `cause`, then assert the surfaced failure is a sanitized// McpInvocationError carrying the expected HTTP status (or none) and never the// upstream body. Each `cause` embeds a "do-not-leak" sentinel.const invocationRejectionCases = [ { name: "wraps callTool rejection with a stable message and status", toolId: "blocked", transport: "streamable-http", cause: new StreamableHTTPError(401, "token=do-not-leak"), expectedStatus: 401 as number | undefined, }, { name: "does not treat MCP protocol error codes as HTTP statuses", toolId: "protocol_error", transport: "streamable-http", cause: new McpError(401, "application-level do-not-leak"), expectedStatus: undefined, }, { name: "does not invent a status from non-HTTP rejection shapes", toolId: "network", transport: "streamable-http", cause: { code: -1, message: "socket said do-not-leak" }, expectedStatus: undefined, }, { name: "extracts the status from the SDK SSE POST error prefix without leaking the body", toolId: "sse_blocked", transport: "sse", cause: { message: "Error POSTing to endpoint (HTTP 403): do-not-leak: upstream auth challenge", }, expectedStatus: 403, },]; describe("invokeMcpTool", () => { for (const testCase of invocationRejectionCases) { it.effect(testCase.name, () => Effect.gen(function* () { const error = yield* invokeMcpTool({ toolId: testCase.toolId, toolName: testCase.toolId, args: {}, transport: testCase.transport, connector: rejectingConnector(testCase.cause), elicit: acceptAll, }).pipe(Effect.flip); expect(Predicate.isTagged(error, "McpInvocationError")).toBe(true); const invocation = error as McpInvocationError; expect(invocation.toolName).toBe(testCase.toolId); expect(invocation).toMatchObject({ message: `MCP tool call failed for ${testCase.toolId}`, }); expect(invocation).toMatchObject({ message: expect.not.stringContaining("do-not-leak"), }); expect(invocation.status).toBe(testCase.expectedStatus); expect("cause" in invocation).toBe(false); }), ); } it.effect("marks OAuth reauthorization rejections without leaking SDK details", () => Effect.gen(function* () { const error = yield* invokeMcpTool({ toolId: "oauth_scope", toolName: "oauth_scope", args: {}, transport: "streamable-http", connector: rejectingConnector( new McpOAuthReauthorizationRequired({ message: "redirect to do-not-leak" }), ), elicit: acceptAll, }).pipe(Effect.flip); expect(Predicate.isTagged(error, "McpOAuthReauthorizationRequired")).toBe(true); expect(error).toMatchObject({ message: expect.not.stringContaining("do-not-leak") }); expect("cause" in error).toBe(false); }), ); it.effect("preserves OAuth reauthorization required during auto connection setup", () => Effect.scoped( Effect.gen(function* () { const server = yield* serveReauthorizationChallengeServer(); const error = yield* invokeMcpTool({ toolId: "oauth_scope", toolName: "oauth_scope", args: {}, transport: "auto", connector: createMcpConnector({ transport: "remote", endpoint: server.url("/mcp"), authProvider: reauthorizationProvider, }), elicit: acceptAll, }).pipe(Effect.flip); expect(Predicate.isTagged(error, "McpOAuthReauthorizationRequired")).toBe(true); }), ), );});
import { describe, expect, it } from "@effect/vitest";
import { Effect, Predicate } from "effect";
import { HttpServerResponse } from "effect/unstable/http";
import type { OAuthClientProvider } from "@modelcontextprotocol/sdk/client/auth.js";
import { StreamableHTTPError } from "@modelcontextprotocol/sdk/client/streamableHttp.js";
import { McpError } from "@modelcontextprotocol/sdk/types.js";
import { ElicitationResponse } from "@executor-js/sdk";
import { serveTestHttpApp } from "@executor-js/sdk/testing";
import { createMcpConnector, type McpConnection, type McpConnector } from "./connection";
import { McpInvocationError, McpOAuthReauthorizationRequired } from "./errors";
import { invokeMcpTool } from "./invoke";
const acceptAll = () => Effect.succeed(ElicitationResponse.make({ action: "accept" }));
const rejectingConnector = (cause: unknown): McpConnector =>
Effect.succeed({
// oxlint-disable-next-line executor/no-double-cast -- boundary: minimal fake MCP client implements only the methods invokeMcpTool calls
client: {
setRequestHandler: () => undefined,
// oxlint-disable-next-line executor/no-promise-reject -- boundary: fake MCP client rejects to exercise invocation error wrapping
callTool: () => Promise.reject(cause),
} as unknown as McpConnection["client"],
close: () => Promise.resolve(),
});
const reauthorizationProvider: OAuthClientProvider = {
get redirectUrl() {
return "http://localhost/oauth/callback";
},
get clientMetadata() {
return {
redirect_uris: ["http://localhost/oauth/callback"],
grant_types: ["authorization_code", "refresh_token"] as string[],
response_types: ["code"] as string[],
token_endpoint_auth_method: "none" as const,
client_name: "Executor",
};
},
clientInformation: () => ({ client_id: "test-client" }),
saveClientInformation: () => undefined,
tokens: () => ({ access_token: "expired-token", token_type: "Bearer" }),
saveTokens: () => undefined,
redirectToAuthorization: async () => {
// oxlint-disable-next-line executor/no-try-catch-or-throw -- boundary: MCP SDK OAuthClientProvider callback can only signal reauthorization by throwing
throw new McpOAuthReauthorizationRequired({ message: "reauthorization required" });
},
saveCodeVerifier: () => undefined,
codeVerifier: () => "unused",
saveDiscoveryState: () => undefined,
discoveryState: () => undefined,
};
const serveReauthorizationChallengeServer = () =>
serveTestHttpApp((request) =>
Effect.sync(() => {
const origin = `http://${request.headers.host ?? "127.0.0.1"}`;
const requestUrl = new URL(request.url, origin);
if (requestUrl.pathname.startsWith("/.well-known/oauth-protected-resource")) {
return HttpServerResponse.jsonUnsafe({
resource: `${origin}/mcp`,
authorization_servers: [origin],
bearer_methods_supported: ["header"],
scopes_supported: ["read"],
});
}
if (
requestUrl.pathname === "/.well-known/oauth-authorization-server" ||
requestUrl.pathname === "/.well-known/openid-configuration"
) {
return HttpServerResponse.jsonUnsafe({
issuer: origin,
authorization_endpoint: `${origin}/authorize`,
token_endpoint: `${origin}/token`,
response_types_supported: ["code"],
grant_types_supported: ["authorization_code", "refresh_token"],
code_challenge_methods_supported: ["S256"],
token_endpoint_auth_methods_supported: ["none"],
scopes_supported: ["read"],
});
}
if (requestUrl.pathname === "/mcp" && request.method === "GET") {
return HttpServerResponse.text("SSE disabled", { status: 405 });
}
return HttpServerResponse.jsonUnsafe(
{ error: "invalid_token" },
{
status: 401,
headers: {
"www-authenticate": `Bearer resource_metadata="${origin}/.well-known/oauth-protected-resource/mcp", error="invalid_token"`,
},
},
);
}),
);
// The status-extraction cases share one shape: dial a connector that rejects
// with `cause`, then assert the surfaced failure is a sanitized
// McpInvocationError carrying the expected HTTP status (or none) and never the
// upstream body. Each `cause` embeds a "do-not-leak" sentinel.
const invocationRejectionCases = [
{
name: "wraps callTool rejection with a stable message and status",
toolId: "blocked",
transport: "streamable-http",
cause: new StreamableHTTPError(401, "token=do-not-leak"),
expectedStatus: 401 as number | undefined,
},
{
name: "does not treat MCP protocol error codes as HTTP statuses",
toolId: "protocol_error",
transport: "streamable-http",
cause: new McpError(401, "application-level do-not-leak"),
expectedStatus: undefined,
},
{
name: "does not invent a status from non-HTTP rejection shapes",
toolId: "network",
transport: "streamable-http",
cause: { code: -1, message: "socket said do-not-leak" },
expectedStatus: undefined,
},
{
name: "extracts the status from the SDK SSE POST error prefix without leaking the body",
toolId: "sse_blocked",
transport: "sse",
cause: {
message: "Error POSTing to endpoint (HTTP 403): do-not-leak: upstream auth challenge",
},
expectedStatus: 403,
},
];
describe("invokeMcpTool", () => {
for (const testCase of invocationRejectionCases) {
it.effect(testCase.name, () =>
Effect.gen(function* () {
const error = yield* invokeMcpTool({
toolId: testCase.toolId,
toolName: testCase.toolId,
args: {},
transport: testCase.transport,
connector: rejectingConnector(testCase.cause),
elicit: acceptAll,
}).pipe(Effect.flip);
expect(Predicate.isTagged(error, "McpInvocationError")).toBe(true);
const invocation = error as McpInvocationError;
expect(invocation.toolName).toBe(testCase.toolId);
expect(invocation).toMatchObject({
message: `MCP tool call failed for ${testCase.toolId}`,
});
expect(invocation).toMatchObject({
message: expect.not.stringContaining("do-not-leak"),
});
expect(invocation.status).toBe(testCase.expectedStatus);
expect("cause" in invocation).toBe(false);
}),
);
}
it.effect("marks OAuth reauthorization rejections without leaking SDK details", () =>
Effect.gen(function* () {
const error = yield* invokeMcpTool({
toolId: "oauth_scope",
toolName: "oauth_scope",
args: {},
transport: "streamable-http",
connector: rejectingConnector(
new McpOAuthReauthorizationRequired({ message: "redirect to do-not-leak" }),
),
elicit: acceptAll,
}).pipe(Effect.flip);
expect(Predicate.isTagged(error, "McpOAuthReauthorizationRequired")).toBe(true);
expect(error).toMatchObject({ message: expect.not.stringContaining("do-not-leak") });
expect("cause" in error).toBe(false);
}),
);
it.effect("preserves OAuth reauthorization required during auto connection setup", () =>
Effect.scoped(
Effect.gen(function* () {
const server = yield* serveReauthorizationChallengeServer();
const error = yield* invokeMcpTool({
toolId: "oauth_scope",
toolName: "oauth_scope",
args: {},
transport: "auto",
connector: createMcpConnector({
transport: "remote",
endpoint: server.url("/mcp"),
authProvider: reauthorizationProvider,
}),
elicit: acceptAll,
}).pipe(Effect.flip);
expect(Predicate.isTagged(error, "McpOAuthReauthorizationRequired")).toBe(true);
}),
),
);
});