History

Fix HubSpot optional scopes for workspace OAuth (#1898)

* Fix HubSpot optional scopes for workspace OAuth * chore: rerun flaky cloud E2E * Honor integration-declared HubSpot optional scopes * Test queue timeout with a controlled clock * Verify optional OAuth scopes through consent and tool execution ---------

Lloyd Vickery committed 2 months ago

Commit 65d939e1 parent 5ecb8819 files · +347 −21Browse files

Showing the changes to apps/cloud/src/engine (1 of 9 files). Show all

Unified · Split

apps/cloud/src/engine/first-party-oauth-clients.ts+1−6
@@ -6,6 +6,7 @@ import { · 5 unmodified lines
6} from "@executor-js/plugin-openapi/providers/microsoft";6} from "@executor-js/plugin-openapi/providers/microsoft";
7import { slackMcpUserScopes } from "@executor-js/react/lib/slack-mcp-oauth";7import { slackMcpUserScopes } from "@executor-js/react/lib/slack-mcp-oauth";
8import { IntegrationSlug, type FirstPartyOAuthClientConfig } from "@executor-js/sdk";8import { IntegrationSlug, type FirstPartyOAuthClientConfig } from "@executor-js/sdk";
9import { HUBSPOT_OPTIONAL_SCOPES } from "@executor-js/sdk/host-internal";
9 10
10import { makeGoogleOAuthListing } from "../analytics/google-oauth-listing";11import { makeGoogleOAuthListing } from "../analytics/google-oauth-listing";
11import { POSTHOG_INGEST_HOST } from "../edge/passthrough";12import { POSTHOG_INGEST_HOST } from "../edge/passthrough";
@@ -152,12 +153,6 @@ const HUBSPOT_REQUIRED_SCOPES = [ · 140 unmodified lines
152 "timeline",153 "timeline",
153] as const;154] as const;
154 155
155const HUBSPOT_OPTIONAL_SCOPES = [
156 "content",
157 "crm.objects.custom.read",
158 "crm.schemas.custom.read",
159] as const;
160
161const MICROSOFT_SCOPES = [156const MICROSOFT_SCOPES = [
162 "User.Read",157 "User.Read",
163 "Calendars.ReadWrite",158 "Calendars.ReadWrite",