History

Remove 1Password plugin from cloud app and fix empty Config.all crash

- Remove @executor/plugin-onepassword dependency and UI integration from cloud app - Guard against Config.all({}) crash in createEnv when shape has no keys - Add .tanstack/ to gitignore

Rhys Sullivan committed 7 months ago

Commit e6861291 parent 635ca264 files · +8 −7Browse files

Unified · Split

4 files
  1. .gitignore +2 −1
  2. apps/cloud/package.json +0 −1
  3. apps/cloud/src/routes/secrets.tsx +1 −4
  4. packages/core/env/src/index.ts +5 −1
.gitignore+2−1
@@ -48,4 +48,5 @@ apps/desktop/resources/ · 47 unmodified lines
4848 .pglite
4949 .claude/
5050 .nitro/
51−.output/
51+.output/
52+.tanstack/
apps/cloud/package.json+0−1
@@ -13,7 +13,6 @@ · 12 unmodified lines
1313 "@executor/plugin-google-discovery": "workspace:*",
1414 "@executor/plugin-graphql": "workspace:*",
1515 "@executor/plugin-mcp": "workspace:*",
16− "@executor/plugin-onepassword": "workspace:*",
1716 "@executor/plugin-openapi": "workspace:*",
1817 "@executor/react": "workspace:*",
1918 "@executor/sdk": "workspace:*",
apps/cloud/src/routes/secrets.tsx+1−4
@@ -1,9 +1,6 @@
11 import { createFileRoute } from "@tanstack/react-router";
22 import { SecretsPage } from "@executor/react/pages/secrets";
3−import { onePasswordSecretProviderPlugin } from "@executor/plugin-onepassword/react";
4−
5−const secretProviderPlugins = [onePasswordSecretProviderPlugin];
63
74 export const Route = createFileRoute("/secrets")({
8− component: () => <SecretsPage secretProviderPlugins={secretProviderPlugins} />,
5+ component: () => <SecretsPage secretProviderPlugins={[]} />,
96 });
packages/core/env/src/index.ts+5−1
@@ -271,9 +271,13 @@ export function createEnv< · 270 unmodified lines
271271
272272 const isServer = opts.isServer ?? (!("window" in globalThis) || "Deno" in globalThis);
273273
274+ const hasKeys = Object.keys(normalizedShape).length > 0;
275+
274276 const finalConfig =
275277 opts.createFinalConfig?.(normalizedShape, isServer) ??
276− (Config.all(normalizedShape) as unknown as TFinalConfig);
278+ (hasKeys
279+ ? (Config.all(normalizedShape) as unknown as TFinalConfig)
280+ : (Config.succeed({}) as unknown as TFinalConfig));
277281
278282 const parsed = Effect.runSync(
279283 Effect.withConfigProvider(ConfigProvider.fromMap(toRuntimeMap(normalizedRuntimeEnv)))(