622 lines · 23.3 KB · Go
RawDownload
// Copyright 2017 The Gitea Authors. All rights reserved.// SPDX-License-Identifier: MIT package integration import (	"fmt"	"net/http"	"net/url"	"strconv"	"sync"	"testing"	"time" 	auth_model "forgejo.org/models/auth"	"forgejo.org/models/db"	issues_model "forgejo.org/models/issues"	repo_model "forgejo.org/models/repo"	"forgejo.org/models/unittest"	user_model "forgejo.org/models/user"	"forgejo.org/modules/setting"	api "forgejo.org/modules/structs"	"forgejo.org/tests" 	"github.com/stretchr/testify/assert"	"github.com/stretchr/testify/require") func TestAPIListIssues(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) 	session := loginUser(t, owner.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadIssue)	link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/issues", owner.Name, repo.Name)) 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}}.Encode()	resp := MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)	var apiIssues []*api.Issue	DecodeJSON(t, resp, &apiIssues)	assert.Len(t, apiIssues, unittest.GetCount(t, &issues_model.Issue{RepoID: repo.ID}))	for _, apiIssue := range apiIssues {		unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: apiIssue.ID, RepoID: repo.ID})	} 	// test milestone filter	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "type": {"all"}, "milestones": {"ignore,milestone1,3,4"}}.Encode()	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	if assert.Len(t, apiIssues, 2) {		assert.EqualValues(t, 3, apiIssues[0].Milestone.ID)		assert.EqualValues(t, 1, apiIssues[1].Milestone.ID)	} 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "created_by": {"user2"}}.Encode()	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	if assert.Len(t, apiIssues, 1) {		assert.EqualValues(t, 5, apiIssues[0].ID)	} 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "assigned_by": {"user1"}}.Encode()	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	if assert.Len(t, apiIssues, 1) {		assert.EqualValues(t, 1, apiIssues[0].ID)	} 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "mentioned_by": {"user4"}}.Encode()	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	if assert.Len(t, apiIssues, 1) {		assert.EqualValues(t, 1, apiIssues[0].ID)	} 	t.Run("Sort", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		link.RawQuery = url.Values{"token": {token}, "sort": {"oldest"}}.Encode()		resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)		DecodeJSON(t, resp, &apiIssues)		if assert.Len(t, apiIssues, 4) {			assert.EqualValues(t, 1, apiIssues[0].ID)			assert.EqualValues(t, 2, apiIssues[1].ID)			assert.EqualValues(t, 3, apiIssues[2].ID)			assert.EqualValues(t, 11, apiIssues[3].ID)		} 		link.RawQuery = url.Values{"token": {token}, "sort": {"newest"}}.Encode()		resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)		DecodeJSON(t, resp, &apiIssues)		if assert.Len(t, apiIssues, 4) {			assert.EqualValues(t, 11, apiIssues[0].ID)			assert.EqualValues(t, 3, apiIssues[1].ID)			assert.EqualValues(t, 2, apiIssues[2].ID)			assert.EqualValues(t, 1, apiIssues[3].ID)		} 		link.RawQuery = url.Values{"token": {token}, "sort": {"recentupdate"}}.Encode()		resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)		DecodeJSON(t, resp, &apiIssues)		if assert.Len(t, apiIssues, 4) {			assert.EqualValues(t, 11, apiIssues[0].ID)			assert.EqualValues(t, 1, apiIssues[1].ID)			assert.EqualValues(t, 2, apiIssues[2].ID)			assert.EqualValues(t, 3, apiIssues[3].ID)		} 		link.RawQuery = url.Values{"token": {token}, "sort": {"leastupdate"}}.Encode()		resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)		DecodeJSON(t, resp, &apiIssues)		if assert.Len(t, apiIssues, 4) {			assert.EqualValues(t, 3, apiIssues[0].ID)			assert.EqualValues(t, 2, apiIssues[1].ID)			assert.EqualValues(t, 1, apiIssues[2].ID)			assert.EqualValues(t, 11, apiIssues[3].ID)		}	})} func TestAPIListIssuesPublicOnly(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})	owner1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo1.OwnerID}) 	session := loginUser(t, owner1.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadIssue)	link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/issues", owner1.Name, repo1.Name))	link.RawQuery = url.Values{"state": {"all"}}.Encode()	req := NewRequest(t, "GET", link.String()).AddTokenAuth(token)	MakeRequest(t, req, http.StatusOK) 	repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})	owner2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo2.OwnerID}) 	session = loginUser(t, owner2.Name)	token = getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadIssue)	link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/issues", owner2.Name, repo2.Name))	link.RawQuery = url.Values{"state": {"all"}}.Encode()	req = NewRequest(t, "GET", link.String()).AddTokenAuth(token)	MakeRequest(t, req, http.StatusOK) 	publicOnlyToken := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadIssue, auth_model.AccessTokenScopePublicOnly)	req = NewRequest(t, "GET", link.String()).AddTokenAuth(publicOnlyToken)	MakeRequest(t, req, http.StatusForbidden)} func TestAPICreateIssue(t *testing.T) {	defer tests.PrepareTestEnv(t)()	const body, title = "apiTestBody", "apiTestTitle" 	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID}) 	session := loginUser(t, owner.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues?state=all", owner.Name, repoBefore.Name)	req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateIssueOption{		Body:     body,		Title:    title,		Assignee: owner.Name,	}).AddTokenAuth(token)	resp := MakeRequest(t, req, http.StatusCreated)	var apiIssue api.Issue	DecodeJSON(t, resp, &apiIssue)	assert.Equal(t, body, apiIssue.Body)	assert.Equal(t, title, apiIssue.Title) 	unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{		RepoID:     repoBefore.ID,		AssigneeID: owner.ID,		Content:    body,		Title:      title,	}) 	repoAfter := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})	assert.Equal(t, repoBefore.NumIssues+1, repoAfter.NumIssues)	assert.Equal(t, repoBefore.NumClosedIssues, repoAfter.NumClosedIssues)} func TestAPICreateIssueParallel(t *testing.T) {	defer tests.PrepareTestEnv(t)()	const body, title = "apiTestBody", "apiTestTitle" 	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID}) 	session := loginUser(t, owner.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues?state=all", owner.Name, repoBefore.Name) 	var wg sync.WaitGroup	for i := 0; i < 10; i++ {		wg.Add(1)		go func(parentT *testing.T, i int) {			parentT.Run(fmt.Sprintf("ParallelCreateIssue_%d", i), func(t *testing.T) {				newTitle := title + strconv.Itoa(i)				newBody := body + strconv.Itoa(i)				req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateIssueOption{					Body:     newBody,					Title:    newTitle,					Assignee: owner.Name,				}).AddTokenAuth(token)				resp := MakeRequest(t, req, http.StatusCreated)				var apiIssue api.Issue				DecodeJSON(t, resp, &apiIssue)				assert.Equal(t, newBody, apiIssue.Body)				assert.Equal(t, newTitle, apiIssue.Title) 				unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{					RepoID:     repoBefore.ID,					AssigneeID: owner.ID,					Content:    newBody,					Title:      newTitle,				}) 				wg.Done()			})		}(t, i)	}	wg.Wait()} func TestAPIEditIssue(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	issueBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID})	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})	require.NoError(t, issueBefore.LoadAttributes(db.DefaultContext))	assert.Equal(t, int64(1019307200), int64(issueBefore.DeadlineUnix))	assert.Equal(t, api.StateOpen, issueBefore.State()) 	session := loginUser(t, owner.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue) 	// update values of issue	issueState := "closed"	removeDeadline := true	milestone := int64(4)	body := "new content!"	title := "new title from api set" 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index)	req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{		State:          &issueState,		RemoveDeadline: &removeDeadline,		Milestone:      &milestone,		Body:           &body,		Title:          title, 		// ToDo change more	}).AddTokenAuth(token)	resp := MakeRequest(t, req, http.StatusCreated)	var apiIssue api.Issue	DecodeJSON(t, resp, &apiIssue) 	issueAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})	repoAfter := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID}) 	// check comment history	unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{IssueID: issueAfter.ID, OldTitle: issueBefore.Title, NewTitle: title})	unittest.AssertExistsAndLoadBean(t, &issues_model.ContentHistory{IssueID: issueAfter.ID, ContentText: body, IsFirstCreated: false}) 	// check deleted user	assert.Equal(t, int64(500), issueAfter.PosterID)	require.NoError(t, issueAfter.LoadAttributes(db.DefaultContext))	assert.Equal(t, int64(-1), issueAfter.PosterID)	assert.Equal(t, int64(-1), issueBefore.PosterID)	assert.Equal(t, int64(-1), apiIssue.Poster.ID) 	// check repo change	assert.Equal(t, repoBefore.NumClosedIssues+1, repoAfter.NumClosedIssues) 	// API response	assert.Equal(t, api.StateClosed, apiIssue.State)	assert.Equal(t, milestone, apiIssue.Milestone.ID)	assert.Equal(t, body, apiIssue.Body)	assert.Nil(t, apiIssue.Deadline)	assert.Equal(t, title, apiIssue.Title) 	// in database	assert.Equal(t, api.StateClosed, issueAfter.State())	assert.Equal(t, milestone, issueAfter.MilestoneID)	assert.Equal(t, int64(0), int64(issueAfter.DeadlineUnix))	assert.Equal(t, body, issueAfter.Content)	assert.Equal(t, title, issueAfter.Title) 	// verify the idempotency of state, milestone, body and title changes	req = NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{		State:     &issueState,		Milestone: &milestone,		Body:      &body,		Title:     title,	}).AddTokenAuth(token)	resp = MakeRequest(t, req, http.StatusCreated)	var apiIssueIdempotent api.Issue	DecodeJSON(t, resp, &apiIssueIdempotent)	assert.Equal(t, apiIssue.State, apiIssueIdempotent.State)	assert.Equal(t, apiIssue.Milestone.Title, apiIssueIdempotent.Milestone.Title)	assert.Equal(t, apiIssue.Body, apiIssueIdempotent.Body)	assert.Equal(t, apiIssue.Title, apiIssueIdempotent.Title)} func TestAPIEditIssueAutoDate(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	issueBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 13})	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID})	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})	require.NoError(t, issueBefore.LoadAttributes(db.DefaultContext)) 	t.Run("WithAutoDate", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		// User2 is not owner, but can update the 'public' issue with auto date		session := loginUser(t, "user2")		token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)		urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index) 		body := "new content!"		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Body: &body,		}).AddTokenAuth(token)		resp := MakeRequest(t, req, http.StatusCreated)		var apiIssue api.Issue		DecodeJSON(t, resp, &apiIssue) 		// the execution of the API call supposedly lasted less than one minute		updatedSince := time.Since(apiIssue.Updated)		assert.LessOrEqual(t, updatedSince, time.Minute) 		issueAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issueBefore.ID})		updatedSince = time.Since(issueAfter.UpdatedUnix.AsTime())		assert.LessOrEqual(t, updatedSince, time.Minute)	}) 	t.Run("WithUpdateDate", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		// User1 is admin, and so can update the issue without auto date		session := loginUser(t, "user1")		token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)		urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index) 		body := "new content, with updated time"		updatedAt := time.Now().Add(-time.Hour).Truncate(time.Second)		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Body:    &body,			Updated: &updatedAt,		}).AddTokenAuth(token)		resp := MakeRequest(t, req, http.StatusCreated)		var apiIssue api.Issue		DecodeJSON(t, resp, &apiIssue) 		// dates are converted into the same tz, in order to compare them		utcTZ, _ := time.LoadLocation("UTC")		assert.Equal(t, updatedAt.In(utcTZ), apiIssue.Updated.In(utcTZ)) 		issueAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issueBefore.ID})		assert.Equal(t, updatedAt.In(utcTZ), issueAfter.UpdatedUnix.AsTime().In(utcTZ))	}) 	t.Run("WithoutPermission", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		// User2 is not owner nor admin, and so can't update the issue without auto date		session := loginUser(t, "user2")		token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)		urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index) 		body := "new content, with updated time"		updatedAt := time.Now().Add(-time.Hour).Truncate(time.Second)		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Body:    &body,			Updated: &updatedAt,		}).AddTokenAuth(token)		resp := MakeRequest(t, req, http.StatusForbidden)		var apiError api.APIError		DecodeJSON(t, resp, &apiError) 		assert.Equal(t, "user needs to have admin or owner right", apiError.Message)	})} func TestAPIEditIssueMilestoneAutoDate(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	issueBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID}) 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})	require.NoError(t, issueBefore.LoadAttributes(db.DefaultContext)) 	session := loginUser(t, owner.Name)	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index) 	t.Run("WithAutoDate", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		milestone := int64(1)		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Milestone: &milestone,		}).AddTokenAuth(token)		MakeRequest(t, req, http.StatusCreated) 		// the execution of the API call supposedly lasted less than one minute		milestoneAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: milestone})		updatedSince := time.Since(milestoneAfter.UpdatedUnix.AsTime())		assert.LessOrEqual(t, updatedSince, time.Minute)	}) 	t.Run("WithPostUpdateDate", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		// Note: the updated_unix field of the test Milestones is set to NULL		// Hence, any date is higher than the Milestone's updated date		updatedAt := time.Now().Add(-time.Hour).Truncate(time.Second)		milestone := int64(2)		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Milestone: &milestone,			Updated:   &updatedAt,		}).AddTokenAuth(token)		MakeRequest(t, req, http.StatusCreated) 		// the milestone date should be set to 'updatedAt'		// dates are converted into the same tz, in order to compare them		utcTZ, _ := time.LoadLocation("UTC")		milestoneAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: milestone})		assert.Equal(t, updatedAt.In(utcTZ), milestoneAfter.UpdatedUnix.AsTime().In(utcTZ))	}) 	t.Run("WithPastUpdateDate", func(t *testing.T) {		defer tests.PrintCurrentTest(t)() 		// Note: This Milestone's updated_unix has been set to Now() by the first subtest		milestone := int64(1)		milestoneBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: milestone}) 		updatedAt := time.Now().Add(-time.Hour).Truncate(time.Second)		req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{			Milestone: &milestone,			Updated:   &updatedAt,		}).AddTokenAuth(token)		MakeRequest(t, req, http.StatusCreated) 		// the milestone date should not change		// dates are converted into the same tz, in order to compare them		utcTZ, _ := time.LoadLocation("UTC")		milestoneAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: milestone})		assert.Equal(t, milestoneAfter.UpdatedUnix.AsTime().In(utcTZ), milestoneBefore.UpdatedUnix.AsTime().In(utcTZ))	})} func TestAPISearchIssues(t *testing.T) {	defer tests.PrepareTestEnv(t)() 	// as this API was used in the frontend, it uses UI page size	expectedIssueCount := 20 // from the fixtures	if expectedIssueCount > setting.UI.IssuePagingNum {		expectedIssueCount = setting.UI.IssuePagingNum	} 	link, _ := url.Parse("/api/v1/repos/issues/search")	token := getUserToken(t, "user1", auth_model.AccessTokenScopeReadIssue)	query := url.Values{}	var apiIssues []*api.Issue 	link.RawQuery = query.Encode()	req := NewRequest(t, "GET", link.String()).AddTokenAuth(token)	resp := MakeRequest(t, req, http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	assert.Len(t, apiIssues, expectedIssueCount) 	publicOnlyToken := getUserToken(t, "user1", auth_model.AccessTokenScopeReadIssue, auth_model.AccessTokenScopePublicOnly)	req = NewRequest(t, "GET", link.String()).AddTokenAuth(publicOnlyToken)	resp = MakeRequest(t, req, http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	assert.Len(t, apiIssues, 15) // 15 public issues 	since := "2000-01-01T00:50:01+00:00" // 946687801	before := time.Unix(999307200, 0).Format(time.RFC3339)	query.Add("since", since)	query.Add("before", before)	link.RawQuery = query.Encode()	req = NewRequest(t, "GET", link.String()).AddTokenAuth(token)	resp = MakeRequest(t, req, http.StatusOK)	DecodeJSON(t, resp, &apiIssues)	assert.Len(t, apiIssues, 11)	query.Del("since")	query.Del("before") 	query.Add("state", "closed")	link.RawQuery = query.Encode()	req = NewRequest(t, "GET", link.String()).AddTokenAuth(token)	resp = MakeRequest(t, req, http.StatusOK)

Lines 1–500 of 622.