History

fix: emphasize tix review commits

Replace the undersized star marker with a filled diamond whose visual weight matches ordinary commit discs while remaining distinct and one cell wide.

Codex committed 3 months ago

Commit a33c0741 parent de864822 files · +4 −4Browse files

Unified · Split

2 files
  1. gix-tix/spec.md +1 −1
  2. gix-tix/src/ui.rs +3 −3
gix-tix/spec.md+1−1
@@ -477,7 +477,7 @@ space first; changes blocks adapt within the remaining history width. · 476 unmodified lines
477477 as unstaged changes.
478478 - Review refs are always traversal tips and remain visible in every ref mode. One
479479 active ref is shown as `review`; multiple refs are shown as `review:N`. Review
480− commits replace the signature disc with a star while retaining independent
480+ commits replace the signature disc with a filled diamond while retaining independent
481481 signature state. Ordinary edits preserve the review header and otherwise keep
482482 their normal signing and lazy-rebase behavior.
483483 - At a checked-out review commit, amend is offered only for staged changes and
gix-tix/src/ui.rs+3−3
@@ -1904,7 +1904,7 @@ fn color_graph( · 1903 unmodified lines
19041904 }
19051905 let cell = &mut frame.buffer_mut()[(area.x + x as u16, area.y)];
19061906 if review && symbol == '●' {
1907− cell.set_symbol("★");
1907+ cell.set_symbol("◆");
19081908 } else if head.is_some() && symbol == '●' {
19091909 cell.set_symbol("@");
19101910 }
@@ -3168,7 +3168,7 @@ mod tests { · 1257 unmodified lines
31683168 }
31693169
31703170 #[test]
3171− fn review_commit_uses_a_star_instead_of_the_signature_disc() -> Result<(), Box<dyn std::error::Error>> {
3171+ fn review_commit_uses_a_diamond_instead_of_the_signature_disc() -> Result<(), Box<dyn std::error::Error>> {
31723172 let mut terminal = Terminal::new(TestBackend::new(2, 1))?;
31733173 terminal.draw(|frame| {
31743174 frame.render_widget(Paragraph::new("●─"), Rect::new(0, 0, 2, 1));
@@ -3182,7 +3182,7 @@ mod tests { · 7 unmodified lines
31823182 Some(true),
31833183 );
31843184 })?;
3185− assert_eq!(terminal.backend().buffer()[(0, 0)].symbol(), "★");
3185+ assert_eq!(terminal.backend().buffer()[(0, 0)].symbol(), "◆");
31863186 assert_eq!(terminal.backend().buffer()[(1, 0)].symbol(), "─");
31873187 Ok(())
31883188 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t