irq_chip_retrigger_hierarchy() returns -ENOSYS if it was not able to find at least one .irq_retrigger() callback implemented in the IRQ domain hierarchy. That's wrong, because check_irq_resend() expects a 0 return value from the callback in case that the hardware assisted resend was not possible. If the return value is non zero the core code assumes hardware resend success and the software resend is not invoked. This results in lost interrupts on platforms where none of the parent irq chips in the hierarchy implements the retrigger callback. This is observable on TI OMAP, where the hierarchy is: ARM GIC <- OMAP wakeupgen <- TI Crossbar Return 0 instead so the software resend mechanism gets invoked. [ tglx: Massaged changelog ]
Showing the changes to kernel (1 of 1 file). Show all
Unified · Split
| @@ -997,7 +997,7 @@ int irq_chip_retrigger_hierarchy(struct irq_data *data) · 996 unmodified lines | |||
| 997 | if (data->chip && data->chip->irq_retrigger) | 997 | if (data->chip && data->chip->irq_retrigger) |
| 998 | return data->chip->irq_retrigger(data); | 998 | return data->chip->irq_retrigger(data); |
| 999 | 999 | ||
| 1000 | return -ENOSYS; | 1000 | return 0; |
| 1001 | } | 1001 | } |
| 1002 | 1002 | ||
| 1003 | /** | 1003 | /** |