History

drm/amdgpu: Replace HQD terminology with slots naming

The term "HQD" is CP-specific and doesn't accurately describe the queue resources for other IP blocks like SDMA, VCN, or VPE. This change: 1. Renames `num_hqds` to `num_slots` in amdgpu_kms.c to better reflect the generic nature of the resource counting 2. Updates the UAPI struct member from `userq_num_hqds` to `userq_num_slots` 3. Maintains the same functionality while using more appropriate terminology

Jesse Zhang committed 1 year ago

Commit 9ffab031 parent 78d0a272 files · +7 −7Browse files

Unified · Split

2 files
  1. drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c +5 −5
  2. include/uapi/drm/amdgpu_drm.h +2 −2
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c+5−5
@@ -399,7 +399,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev, · 398 unmodified lines
399399 uint32_t ib_size_alignment = 0;
400400 enum amd_ip_block_type type;
401401 unsigned int num_rings = 0;
402− uint32_t num_hqds = 0;
402+ uint32_t num_slots = 0;
403403 unsigned int i, j;
404404
405405 if (info->query_hw_ip.ip_instance >= AMDGPU_HW_IP_INSTANCE_MAX_COUNT)
@@ -415,7 +415,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev, · 9 unmodified lines
415415
416416 if (!adev->gfx.disable_uq) {
417417 for (i = 0; i < AMDGPU_MES_MAX_GFX_PIPES; i++)
418− num_hqds += hweight32(adev->mes.gfx_hqd_mask[i]);
418+ num_slots += hweight32(adev->mes.gfx_hqd_mask[i]);
419419 }
420420
421421 ib_start_alignment = 32;
@@ -430,7 +430,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev, · 8 unmodified lines
430430
431431 if (!adev->sdma.disable_uq) {
432432 for (i = 0; i < AMDGPU_MES_MAX_COMPUTE_PIPES; i++)
433− num_hqds += hweight32(adev->mes.compute_hqd_mask[i]);
433+ num_slots += hweight32(adev->mes.compute_hqd_mask[i]);
434434 }
435435
436436 ib_start_alignment = 32;
@@ -445,7 +445,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev, · 8 unmodified lines
445445
446446 if (!adev->gfx.disable_uq) {
447447 for (i = 0; i < AMDGPU_MES_MAX_SDMA_PIPES; i++)
448− num_hqds += hweight32(adev->mes.sdma_hqd_mask[i]);
448+ num_slots += hweight32(adev->mes.sdma_hqd_mask[i]);
449449 }
450450
451451 ib_start_alignment = 256;
@@ -589,7 +589,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev, · 137 unmodified lines
589589 }
590590 result->capabilities_flags = 0;
591591 result->available_rings = (1 << num_rings) - 1;
592− result->userq_num_hqds = num_hqds;
592+ result->userq_num_slots = num_slots;
593593 result->ib_start_alignment = ib_start_alignment;
594594 result->ib_size_alignment = ib_size_alignment;
595595 return 0;
include/uapi/drm/amdgpu_drm.h+2−2
@@ -1493,8 +1493,8 @@ struct drm_amdgpu_info_hw_ip { · 1492 unmodified lines
14931493 __u32 available_rings;
14941494 /** version info: bits 23:16 major, 15:8 minor, 7:0 revision */
14951495 __u32 ip_discovery_version;
1496− /* Userq available hqds */
1497− __u32 userq_num_hqds;
1496+ /* Userq available slots */
1497+ __u32 userq_num_slots;
14981498 };
14991499
15001500 /* GFX metadata BO sizes and alignment info (in bytes) */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t