History

drm: integer overflow in drm_mode_dirtyfb_ioctl()

There is a potential integer overflow in drm_mode_dirtyfb_ioctl() if userspace passes in a large num_clips. The call to kmalloc would allocate a small buffer, and the call to fb->funcs->dirty may result in a memory corruption.

Xi Wang committed 14 years ago

Commit a5cd3351 parent c9168742 files · +6 −0Browse files

Unified · Split

2 files
  1. drivers/gpu/drm/drm_crtc.c +4 −0
  2. include/drm/drm_mode.h +2 −0
drivers/gpu/drm/drm_crtc.c+4−0
@@ -1873,6 +1873,10 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev, · 1872 unmodified lines
18731873 }
18741874
18751875 if (num_clips && clips_ptr) {
1876+ if (num_clips < 0 || num_clips > DRM_MODE_FB_DIRTY_MAX_CLIPS) {
1877+ ret = -EINVAL;
1878+ goto out_err1;
1879+ }
18761880 clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL);
18771881 if (!clips) {
18781882 ret = -ENOMEM;
include/drm/drm_mode.h+2−0
@@ -235,6 +235,8 @@ struct drm_mode_fb_cmd { · 234 unmodified lines
235235 #define DRM_MODE_FB_DIRTY_ANNOTATE_FILL 0x02
236236 #define DRM_MODE_FB_DIRTY_FLAGS 0x03
237237
238+#define DRM_MODE_FB_DIRTY_MAX_CLIPS 256
239+
238240 /*
239241 * Mark a region of a framebuffer as dirty.
240242 *

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t