Pull Devicetree fixes from Rob Herring: "Fix several warnings/errors in validation of binding schemas" * tag 'devicetree-fixes-for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux: dt-bindings: pinctrl: stm32: Fix missing 'clocks' property in examples dt-bindings: iio: ad7124: Fix dtc warnings in example dt-bindings: iio: avia-hx711: Fix avdd-supply typo in example dt-bindings: pinctrl: aspeed: Fix AST2500 example errors dt-bindings: pinctrl: aspeed: Fix 'compatible' schema errors dt-bindings: riscv: Limit cpus schema to only check RiscV 'cpu' nodes dt-bindings: Ensure child nodes are of type 'object'
Unified · Split
| @@ -42,6 +42,7 @@ properties: · 41 unmodified lines | ||
| 42 | 42 | |
| 43 | 43 | patternProperties: |
| 44 | 44 | "^.*@[0-9a-fA-F]+$": |
| 45 | + type: object | |
| 45 | 46 | properties: |
| 46 | 47 | reg: |
| 47 | 48 | maxItems: 1 |
| @@ -114,42 +114,47 @@ patternProperties: · 113 unmodified lines | ||
| 114 | 114 | |
| 115 | 115 | examples: |
| 116 | 116 | - | |
| 117 | − adc@0 { | |
| 118 | − compatible = "adi,ad7124-4"; | |
| 119 | − reg = <0>; | |
| 120 | − spi-max-frequency = <5000000>; | |
| 121 | − interrupts = <25 2>; | |
| 122 | − interrupt-parent = <&gpio>; | |
| 123 | − refin1-supply = <&adc_vref>; | |
| 124 | − clocks = <&ad7124_mclk>; | |
| 125 | − clock-names = "mclk"; | |
| 126 | − | |
| 117 | + spi { | |
| 127 | 118 | #address-cells = <1>; |
| 128 | 119 | #size-cells = <0>; |
| 129 | 120 | |
| 130 | − channel@0 { | |
| 121 | + adc@0 { | |
| 122 | + compatible = "adi,ad7124-4"; | |
| 131 | 123 | reg = <0>; |
| 132 | − diff-channels = <0 1>; | |
| 133 | − adi,reference-select = <0>; | |
| 134 | − adi,buffered-positive; | |
| 135 | − }; | |
| 136 | − | |
| 137 | − channel@1 { | |
| 138 | − reg = <1>; | |
| 139 | − bipolar; | |
| 140 | − diff-channels = <2 3>; | |
| 141 | − adi,reference-select = <0>; | |
| 142 | − adi,buffered-positive; | |
| 143 | − adi,buffered-negative; | |
| 144 | − }; | |
| 145 | − | |
| 146 | − channel@2 { | |
| 147 | − reg = <2>; | |
| 148 | − diff-channels = <4 5>; | |
| 149 | − }; | |
| 150 | − | |
| 151 | − channel@3 { | |
| 152 | − reg = <3>; | |
| 153 | − diff-channels = <6 7>; | |
| 124 | + spi-max-frequency = <5000000>; | |
| 125 | + interrupts = <25 2>; | |
| 126 | + interrupt-parent = <&gpio>; | |
| 127 | + refin1-supply = <&adc_vref>; | |
| 128 | + clocks = <&ad7124_mclk>; | |
| 129 | + clock-names = "mclk"; | |
| 130 | + | |
| 131 | + #address-cells = <1>; | |
| 132 | + #size-cells = <0>; | |
| 133 | + | |
| 134 | + channel@0 { | |
| 135 | + reg = <0>; | |
| 136 | + diff-channels = <0 1>; | |
| 137 | + adi,reference-select = <0>; | |
| 138 | + adi,buffered-positive; | |
| 139 | + }; | |
| 140 | + | |
| 141 | + channel@1 { | |
| 142 | + reg = <1>; | |
| 143 | + bipolar; | |
| 144 | + diff-channels = <2 3>; | |
| 145 | + adi,reference-select = <0>; | |
| 146 | + adi,buffered-positive; | |
| 147 | + adi,buffered-negative; | |
| 148 | + }; | |
| 149 | + | |
| 150 | + channel@2 { | |
| 151 | + reg = <2>; | |
| 152 | + diff-channels = <4 5>; | |
| 153 | + }; | |
| 154 | + | |
| 155 | + channel@3 { | |
| 156 | + reg = <3>; | |
| 157 | + diff-channels = <6 7>; | |
| 158 | + }; | |
| 154 | 159 | }; |
| 155 | 160 | }; |
| @@ -61,6 +61,6 @@ examples: · 60 unmodified lines | ||
| 61 | 61 | compatible = "avia,hx711"; |
| 62 | 62 | sck-gpios = <&gpio3 10 GPIO_ACTIVE_HIGH>; |
| 63 | 63 | dout-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>; |
| 64 | − avdd-suppy = <&avdd>; | |
| 64 | + avdd-supply = <&avdd>; | |
| 65 | 65 | clock-frequency = <100000>; |
| 66 | 66 | }; |
| @@ -55,6 +55,7 @@ patternProperties: · 54 unmodified lines | ||
| 55 | 55 | "^pinctrl-[0-9]+$": true |
| 56 | 56 | |
| 57 | 57 | "^nand@[a-f0-9]+$": |
| 58 | + type: object | |
| 58 | 59 | properties: |
| 59 | 60 | reg: |
| 60 | 61 | minimum: 0 |
| @@ -40,6 +40,7 @@ properties: · 39 unmodified lines | ||
| 40 | 40 | |
| 41 | 41 | patternProperties: |
| 42 | 42 | "^nand@[a-f0-9]$": |
| 43 | + type: object | |
| 43 | 44 | properties: |
| 44 | 45 | reg: |
| 45 | 46 | description: |
| @@ -22,7 +22,9 @@ description: |+ · 21 unmodified lines | ||
| 22 | 22 | |
| 23 | 23 | properties: |
| 24 | 24 | compatible: |
| 25 | − enum: [ aspeed,ast2400-pinctrl, aspeed,g4-pinctrl ] | |
| 25 | + enum: | |
| 26 | + - aspeed,ast2400-pinctrl | |
| 27 | + - aspeed,g4-pinctrl | |
| 26 | 28 | |
| 27 | 29 | patternProperties: |
| 28 | 30 | '^.*$': |
| @@ -22,7 +22,9 @@ description: |+ · 21 unmodified lines | ||
| 22 | 22 | |
| 23 | 23 | properties: |
| 24 | 24 | compatible: |
| 25 | − enum: [ aspeed,ast2500-pinctrl, aspeed,g5-pinctrl ] | |
| 25 | + enum: | |
| 26 | + - aspeed,ast2500-pinctrl | |
| 27 | + - aspeed,g5-pinctrl | |
| 26 | 28 | aspeed,external-nodes: |
| 27 | 29 | minItems: 2 |
| 28 | 30 | maxItems: 2 |
| @@ -74,9 +76,6 @@ required: · 45 unmodified lines | ||
| 74 | 76 | |
| 75 | 77 | examples: |
| 76 | 78 | - | |
| 77 | − compatible = "simple-bus"; | |
| 78 | − ranges; | |
| 79 | − | |
| 80 | 79 | apb { |
| 81 | 80 | compatible = "simple-bus"; |
| 82 | 81 | #address-cells = <1>; |
| @@ -89,7 +88,7 @@ examples: · 6 unmodified lines | ||
| 89 | 88 | |
| 90 | 89 | pinctrl: pinctrl { |
| 91 | 90 | compatible = "aspeed,g5-pinctrl"; |
| 92 | − aspeed,external-nodes = <&gfx &lhc>; | |
| 91 | + aspeed,external-nodes = <&gfx>, <&lhc>; | |
| 93 | 92 | |
| 94 | 93 | pinctrl_i2c3_default: i2c3_default { |
| 95 | 94 | function = "I2C3"; |
| @@ -55,6 +55,7 @@ properties: · 54 unmodified lines | ||
| 55 | 55 | |
| 56 | 56 | patternProperties: |
| 57 | 57 | '^gpio@[0-9a-f]*$': |
| 58 | + type: object | |
| 58 | 59 | properties: |
| 59 | 60 | gpio-controller: true |
| 60 | 61 | '#gpio-cells': |
| @@ -113,8 +114,10 @@ patternProperties: · 52 unmodified lines | ||
| 113 | 114 | - st,bank-name |
| 114 | 115 | |
| 115 | 116 | '-[0-9]*$': |
| 117 | + type: object | |
| 116 | 118 | patternProperties: |
| 117 | 119 | '^pins': |
| 120 | + type: object | |
| 118 | 121 | description: | |
| 119 | 122 | A pinctrl node should contain at least one subnode representing the |
| 120 | 123 | pinctrl group available on the machine. Each subnode will list the |
| @@ -194,6 +197,7 @@ required: · 73 unmodified lines | ||
| 194 | 197 | examples: |
| 195 | 198 | - | |
| 196 | 199 | #include <dt-bindings/pinctrl/stm32-pinfunc.h> |
| 200 | + #include <dt-bindings/mfd/stm32f4-rcc.h> | |
| 197 | 201 | //Example 1 |
| 198 | 202 | pinctrl@40020000 { |
| 199 | 203 | #address-cells = <1>; |
| @@ -207,6 +211,7 @@ examples: · 7 unmodified lines | ||
| 207 | 211 | #gpio-cells = <2>; |
| 208 | 212 | reg = <0x0 0x400>; |
| 209 | 213 | resets = <&reset_ahb1 0>; |
| 214 | + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)>; | |
| 210 | 215 | st,bank-name = "GPIOA"; |
| 211 | 216 | }; |
| 212 | 217 | }; |
| @@ -224,6 +229,7 @@ examples: · 11 unmodified lines | ||
| 224 | 229 | #gpio-cells = <2>; |
| 225 | 230 | reg = <0x1000 0x400>; |
| 226 | 231 | resets = <&reset_ahb1 0>; |
| 232 | + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOB)>; | |
| 227 | 233 | st,bank-name = "GPIOB"; |
| 228 | 234 | gpio-ranges = <&pinctrl 0 0 16>; |
| 229 | 235 | }; |
| @@ -233,6 +239,7 @@ examples: · 3 unmodified lines | ||
| 233 | 239 | #gpio-cells = <2>; |
| 234 | 240 | reg = <0x2000 0x400>; |
| 235 | 241 | resets = <&reset_ahb1 0>; |
| 242 | + clocks = <&rcc 0 STM32F4_AHB1_CLOCK(GPIOC)>; | |
| 236 | 243 | st,bank-name = "GPIOC"; |
| 237 | 244 | ngpios = <5>; |
| 238 | 245 | gpio-ranges = <&pinctrl 0 16 3>, |
| @@ -10,97 +10,76 @@ maintainers: · 9 unmodified lines | ||
| 10 | 10 | - Paul Walmsley <paul.walmsley@sifive.com> |
| 11 | 11 | - Palmer Dabbelt <palmer@sifive.com> |
| 12 | 12 | |
| 13 | −allOf: | |
| 14 | − - $ref: /schemas/cpus.yaml# | |
| 15 | − | |
| 16 | 13 | properties: |
| 17 | − $nodename: | |
| 18 | − const: cpus | |
| 19 | − description: Container of cpu nodes | |
| 20 | − | |
| 21 | − '#address-cells': | |
| 22 | − const: 1 | |
| 23 | − description: | | |
| 24 | − A single unsigned 32-bit integer uniquely identifies each RISC-V | |
| 25 | − hart in a system. (See the "reg" node under the "cpu" node, | |
| 26 | − below). | |
| 27 | − | |
| 28 | − '#size-cells': | |
| 29 | − const: 0 | |
| 14 | + compatible: | |
| 15 | + items: | |
| 16 | + - enum: | |
| 17 | + - sifive,rocket0 | |
| 18 | + - sifive,e5 | |
| 19 | + - sifive,e51 | |
| 20 | + - sifive,u54-mc | |
| 21 | + - sifive,u54 | |
| 22 | + - sifive,u5 | |
| 23 | + - const: riscv | |
| 24 | + description: | |
| 25 | + Identifies that the hart uses the RISC-V instruction set | |
| 26 | + and identifies the type of the hart. | |
| 27 | + | |
| 28 | + mmu-type: | |
| 29 | + allOf: | |
| 30 | + - $ref: "/schemas/types.yaml#/definitions/string" | |
| 31 | + - enum: | |
| 32 | + - riscv,sv32 | |
| 33 | + - riscv,sv39 | |
| 34 | + - riscv,sv48 | |
| 35 | + description: | |
| 36 | + Identifies the MMU address translation mode used on this | |
| 37 | + hart. These values originate from the RISC-V Privileged | |
| 38 | + Specification document, available from | |
| 39 | + https://riscv.org/specifications/ | |
| 40 | + | |
| 41 | + riscv,isa: | |
| 42 | + allOf: | |
| 43 | + - $ref: "/schemas/types.yaml#/definitions/string" | |
| 44 | + - enum: | |
| 45 | + - rv64imac | |
| 46 | + - rv64imafdc | |
| 47 | + description: | |
| 48 | + Identifies the specific RISC-V instruction set architecture | |
| 49 | + supported by the hart. These are documented in the RISC-V | |
| 50 | + User-Level ISA document, available from | |
| 51 | + https://riscv.org/specifications/ | |
| 52 | + | |
| 53 | + timebase-frequency: | |
| 54 | + type: integer | |
| 55 | + minimum: 1 | |
| 56 | + description: | |
| 57 | + Specifies the clock frequency of the system timer in Hz. | |
| 58 | + This value is common to all harts on a single system image. | |
| 59 | + | |
| 60 | + interrupt-controller: | |
| 61 | + type: object | |
| 62 | + description: Describes the CPU's local interrupt controller | |
| 30 | 63 | |
| 31 | −patternProperties: | |
| 32 | − '^cpu@[0-9a-f]+$': | |
| 33 | 64 | properties: |
| 34 | − compatible: | |
| 35 | − type: array | |
| 36 | − items: | |
| 37 | − - enum: | |
| 38 | − - sifive,rocket0 | |
| 39 | − - sifive,e5 | |
| 40 | − - sifive,e51 | |
| 41 | − - sifive,u54-mc | |
| 42 | − - sifive,u54 | |
| 43 | − - sifive,u5 | |
| 44 | − - const: riscv | |
| 45 | − description: | |
| 46 | − Identifies that the hart uses the RISC-V instruction set | |
| 47 | − and identifies the type of the hart. | |
| 48 | − | |
| 49 | − mmu-type: | |
| 50 | − allOf: | |
| 51 | − - $ref: "/schemas/types.yaml#/definitions/string" | |
| 52 | − - enum: | |
| 53 | − - riscv,sv32 | |
| 54 | − - riscv,sv39 | |
| 55 | − - riscv,sv48 | |
| 56 | − description: | |
| 57 | − Identifies the MMU address translation mode used on this | |
| 58 | − hart. These values originate from the RISC-V Privileged | |
| 59 | − Specification document, available from | |
| 60 | − https://riscv.org/specifications/ | |
| 61 | − | |
| 62 | − riscv,isa: | |
| 63 | − allOf: | |
| 64 | − - $ref: "/schemas/types.yaml#/definitions/string" | |
| 65 | − - enum: | |
| 66 | − - rv64imac | |
| 67 | − - rv64imafdc | |
| 68 | − description: | |
| 69 | − Identifies the specific RISC-V instruction set architecture | |
| 70 | − supported by the hart. These are documented in the RISC-V | |
| 71 | − User-Level ISA document, available from | |
| 72 | − https://riscv.org/specifications/ | |
| 65 | + '#interrupt-cells': | |
| 66 | + const: 1 | |
| 73 | 67 | |
| 74 | − timebase-frequency: | |
| 75 | − type: integer | |
| 76 | − minimum: 1 | |
| 77 | − description: | |
| 78 | − Specifies the clock frequency of the system timer in Hz. | |
| 79 | − This value is common to all harts on a single system image. | |
| 80 | − | |
| 81 | − interrupt-controller: | |
| 82 | − type: object | |
| 83 | − description: Describes the CPU's local interrupt controller | |
| 84 | − | |
| 85 | − properties: | |
| 86 | − '#interrupt-cells': | |
| 87 | − const: 1 | |
| 88 | − | |
| 89 | − compatible: | |
| 90 | − const: riscv,cpu-intc | |
| 91 | − | |
| 92 | − interrupt-controller: true | |
| 68 | + compatible: | |
| 69 | + const: riscv,cpu-intc | |
| 93 | 70 | |
| 94 | − required: | |
| 95 | − - '#interrupt-cells' | |
| 96 | − - compatible | |
| 97 | − - interrupt-controller | |
| 71 | + interrupt-controller: true | |
| 98 | 72 | |
| 99 | 73 | required: |
| 100 | − - riscv,isa | |
| 101 | − - timebase-frequency | |
| 74 | + - '#interrupt-cells' | |
| 75 | + - compatible | |
| 102 | 76 | - interrupt-controller |
| 103 | 77 | |
| 78 | +required: | |
| 79 | + - riscv,isa | |
| 80 | + - timebase-frequency | |
| 81 | + - interrupt-controller | |
| 82 | + | |
| 104 | 83 | examples: |
| 105 | 84 | - | |
| 106 | 85 | // Example 1: SiFive Freedom U540G Development Kit |
| @@ -50,6 +50,7 @@ properties: · 49 unmodified lines | ||
| 50 | 50 | |
| 51 | 51 | patternProperties: |
| 52 | 52 | "^.*@[0-9a-f]+": |
| 53 | + type: object | |
| 53 | 54 | properties: |
| 54 | 55 | reg: |
| 55 | 56 | items: |
| @@ -55,6 +55,7 @@ properties: · 54 unmodified lines | ||
| 55 | 55 | |
| 56 | 56 | patternProperties: |
| 57 | 57 | "^.*@[0-9a-f]+": |
| 58 | + type: object | |
| 58 | 59 | properties: |
| 59 | 60 | reg: |
| 60 | 61 | items: |