History

numa: make "nr_online_nodes" unsigned int

Number of online NUMA nodes can't be negative as well. This doesn't save space as the variable is used only in 32-bit context, but do it anyway for consistency.

Alexey Dobriyan committed 7 years ago

Commit ce0725f1 parent b9726c22 files · +4 −4Browse files

Unified · Split

2 files
  1. include/linux/nodemask.h +2 −2
  2. mm/page_alloc.c +2 −2
include/linux/nodemask.h+2−2
@@ -445,7 +445,7 @@ static inline int next_memory_node(int nid) · 444 unmodified lines
445445 }
446446
447447 extern unsigned int nr_node_ids;
448−extern int nr_online_nodes;
448+extern unsigned int nr_online_nodes;
449449
450450 static inline void node_set_online(int nid)
451451 {
@@ -486,7 +486,7 @@ static inline int num_node_state(enum node_states state) · 34 unmodified lines
486486 #define first_memory_node 0
487487 #define next_online_node(nid) (MAX_NUMNODES)
488488 #define nr_node_ids 1U
489−#define nr_online_nodes 1
489+#define nr_online_nodes 1U
490490
491491 #define node_set_online(node) node_set_state((node), N_ONLINE)
492492 #define node_set_offline(node) node_clear_state((node), N_ONLINE)
mm/page_alloc.c+2−2
@@ -290,7 +290,7 @@ EXPORT_SYMBOL(movable_zone); · 289 unmodified lines
290290
291291 #if MAX_NUMNODES > 1
292292 unsigned int nr_node_ids __read_mostly = MAX_NUMNODES;
293−int nr_online_nodes __read_mostly = 1;
293+unsigned int nr_online_nodes __read_mostly = 1;
294294 EXPORT_SYMBOL(nr_node_ids);
295295 EXPORT_SYMBOL(nr_online_nodes);
296296 #endif
@@ -5664,7 +5664,7 @@ void __ref build_all_zonelists(pg_data_t *pgdat) · 5367 unmodified lines
56645664 else
56655665 page_group_by_mobility_disabled = 0;
56665666
5667− pr_info("Built %i zonelists, mobility grouping %s. Total pages: %ld\n",
5667+ pr_info("Built %u zonelists, mobility grouping %s. Total pages: %ld\n",
56685668 nr_online_nodes,
56695669 page_group_by_mobility_disabled ? "off" : "on",
56705670 vm_total_pages);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t