History

proc: use named enums for better readability

Alexey Gladkov committed 6 years ago

Commit e61bb8b1 parent 1c6c4d14 files · +8 −8Browse files

Unified · Split

4 files
  1. fs/proc/base.c +1 −1
  2. fs/proc/inode.c +1 −1
  3. fs/proc/root.c +2 −2
  4. include/linux/proc_fs.h +4 −4
fs/proc/base.c+1−1
@@ -699,7 +699,7 @@ int proc_setattr(struct dentry *dentry, struct iattr *attr) · 698 unmodified lines
699699 */
700700 static bool has_pid_permissions(struct proc_fs_info *fs_info,
701701 struct task_struct *task,
702− int hide_pid_min)
702+ enum proc_hidepid hide_pid_min)
703703 {
704704 /*
705705 * If 'hidpid' mount option is set force a ptrace check,
fs/proc/inode.c+1−1
@@ -166,7 +166,7 @@ void proc_invalidate_siblings_dcache(struct hlist_head *inodes, spinlock_t *lock · 165 unmodified lines
166166 deactivate_super(old_sb);
167167 }
168168
169−static inline const char *hidepid2str(int v)
169+static inline const char *hidepid2str(enum proc_hidepid v)
170170 {
171171 switch (v) {
172172 case HIDEPID_OFF: return "off";
fs/proc/root.c+2−2
@@ -32,9 +32,9 @@ · 31 unmodified lines
3232 struct proc_fs_context {
3333 struct pid_namespace *pid_ns;
3434 unsigned int mask;
35− int hidepid;
35+ enum proc_hidepid hidepid;
3636 int gid;
37− int pidonly;
37+ enum proc_pidonly pidonly;
3838 };
3939
4040 enum proc_param {
include/linux/proc_fs.h+4−4
@@ -43,7 +43,7 @@ struct proc_ops { · 42 unmodified lines
4343 } __randomize_layout;
4444
4545 /* definitions for hide_pid field */
46−enum {
46+enum proc_hidepid {
4747 HIDEPID_OFF = 0,
4848 HIDEPID_NO_ACCESS = 1,
4949 HIDEPID_INVISIBLE = 2,
@@ -51,7 +51,7 @@ enum { · 1 unmodified line
5151 };
5252
5353 /* definitions for proc mount option pidonly */
54−enum {
54+enum proc_pidonly {
5555 PROC_PIDONLY_OFF = 0,
5656 PROC_PIDONLY_ON = 1,
5757 };
@@ -61,8 +61,8 @@ struct proc_fs_info { · 3 unmodified lines
6161 struct dentry *proc_self; /* For /proc/self */
6262 struct dentry *proc_thread_self; /* For /proc/thread-self */
6363 kgid_t pid_gid;
64− int hide_pid;
65− int pidonly;
64+ enum proc_hidepid hide_pid;
65+ enum proc_pidonly pidonly;
6666 };
6767
6868 static inline struct proc_fs_info *proc_sb_info(struct super_block *sb)