History

exit: Mark do_group_exit() __noreturn

vmlinux.o: warning: objtool: get_signal()+0x108: unreachable instruction 0000 000000000007f930 <get_signal>: ... 0103 7fa33: e8 00 00 00 00 call 7fa38 <get_signal+0x108> 7fa34: R_X86_64_PLT32 do_group_exit-0x4 0108 7fa38: 41 8b 45 74 mov 0x74(%r13),%eax

Peter Zijlstra committed 4 years ago

Commit eae654f1 parent f9cdf7c3 files · +3 −2Browse files

Unified · Split

3 files
  1. include/linux/sched/task.h +1 −1
  2. kernel/exit.c +1 −1
  3. tools/objtool/check.c +1 −0
include/linux/sched/task.h+1−1
@@ -79,7 +79,7 @@ static inline void exit_thread(struct task_struct *tsk) · 78 unmodified lines
7979 {
8080 }
8181 #endif
82−extern void do_group_exit(int);
82+extern __noreturn void do_group_exit(int);
8383
8484 extern void exit_files(struct task_struct *);
8585 extern void exit_itimers(struct signal_struct *);
kernel/exit.c+1−1
@@ -906,7 +906,7 @@ SYSCALL_DEFINE1(exit, int, error_code) · 905 unmodified lines
906906 * Take down every thread in the group. This is called by fatal signals
907907 * as well as by sys_exit_group (below).
908908 */
909−void
909+void __noreturn
910910 do_group_exit(int exit_code)
911911 {
912912 struct signal_struct *sig = current->signal;
tools/objtool/check.c+1−0
@@ -181,6 +181,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · 180 unmodified lines
181181 "kunit_try_catch_throw",
182182 "xen_start_kernel",
183183 "cpu_bringup_and_idle",
184+ "do_group_exit",
184185 "stop_this_cpu",
185186 };
186187

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t