drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

This code dereferences "page->pvr_dev" and then checked for NULL on the next line. Re-order it to avoid a potential NULL pointer dereference.

Dan Carpenter committed 2 years ago

Commit fca94481 parent b84135e1 file · +3 −1Browse files

Unified · Split

@@ -316,12 +316,14 @@ err_free_page: · 315 unmodified lines
316	316	static void
317	317	pvr_mmu_backing_page_fini(struct pvr_mmu_backing_page *page)
318	318	{
319		− struct device *dev = from_pvr_device(page->pvr_dev)->dev;
	319	+ struct device *dev;
320	320
321	321	/* Do nothing if no allocation is present. */
322	322	if (!page->pvr_dev)
323	323	return;
324	324
	325	+ dev = from_pvr_device(page->pvr_dev)->dev;
	326	+
325	327	dma_unmap_page(dev, page->dma_addr, PVR_MMU_BACKING_PAGE_SIZE,
326	328	DMA_TO_DEVICE);
327	329

Keyboard shortcuts