import { describe, expect, it } from "vitest"; import { MessageId, TurnId, type OrchestrationCheckpointSummary, type ReviewDiffPreviewSource,} from "@t3tools/contracts"; import { buildReviewListItems, buildReviewParsedDiff, buildReviewSectionItems, getDefaultReviewSectionId, getReviewFilePreviewState, getReviewSectionIdForCheckpoint, type ReviewRenderableFile,} from "./reviewModel"; function makeCheckpoint( input: Partial<OrchestrationCheckpointSummary> & Pick<OrchestrationCheckpointSummary, "turnId" | "checkpointTurnCount" | "completedAt">,): OrchestrationCheckpointSummary { return { checkpointRef: `refs/t3/checkpoints/thread/${input.checkpointTurnCount}` as any, status: "ready", files: [], assistantMessageId: MessageId.make(`msg-${input.checkpointTurnCount}`), ...input, };} function makeRenderableFile( input: Partial<ReviewRenderableFile> & Pick<ReviewRenderableFile, "path">,): ReviewRenderableFile { return { id: input.path, cacheKey: input.path, previousPath: null, changeType: "new", additions: 0, deletions: 0, languageHint: null, additionLines: [], deletionLines: [], rows: [], ...input, };} describe("buildReviewSectionItems", () => { it("keeps one chip per checkpoint and appends git sources", () => { const checkpoints = [ makeCheckpoint({ turnId: TurnId.make("turn-1"), checkpointTurnCount: 1, completedAt: "2026-04-01T00:00:00.000Z", }), makeCheckpoint({ turnId: TurnId.make("turn-2"), checkpointTurnCount: 2, completedAt: "2026-04-02T00:00:00.000Z", }), ]; const gitSections: ReviewDiffPreviewSource[] = [ { id: "working-tree", kind: "working-tree", title: "Dirty worktree", baseRef: "HEAD", headRef: null, diff: "diff --git a/a.ts b/a.ts", diffHash: "hash-dirty", truncated: false, }, { id: "branch-range", kind: "branch-range", title: "Against main", baseRef: "main", headRef: "feature", diff: "diff --git a/a.ts b/a.ts", diffHash: "hash-base", truncated: false, }, ]; const loadedTurnId = getReviewSectionIdForCheckpoint(checkpoints[0]); const items = buildReviewSectionItems({ checkpoints, gitSections, turnDiffById: { [loadedTurnId]: "diff --git a/loaded.ts b/loaded.ts", }, loadingTurnIds: { [getReviewSectionIdForCheckpoint(checkpoints[1])]: true, }, loadingGitSections: false, }); expect(items.map((item) => item.id)).toEqual([ "turn:2", "turn:1", "git:working-tree", "git:branch-range", ]); expect(items[0]).toMatchObject({ isLoading: true, diff: null }); expect(items[1]).toMatchObject({ isLoading: false, diff: expect.stringContaining("loaded.ts"), }); expect(getDefaultReviewSectionId(items)).toBe("turn:2"); }); it("shows dirty worktree while git preview is loading", () => { const items = buildReviewSectionItems({ checkpoints: [], gitSections: [], turnDiffById: {}, loadingTurnIds: {}, loadingGitSections: true, }); expect(items).toEqual([ expect.objectContaining({ id: "git:working-tree", kind: "working-tree", title: "Dirty worktree", subtitle: "Tracked, staged, and untracked worktree changes", diff: null, isLoading: true, }), ]); expect(getDefaultReviewSectionId(items)).toBe("git:working-tree"); });}); describe("buildReviewParsedDiff", () => { it("builds renderable rows from a unified patch", () => { const parsed = buildReviewParsedDiff( [ "diff --git a/apps/mobile/src/a.ts b/apps/mobile/src/a.ts", "index 1111111..2222222 100644", "--- a/apps/mobile/src/a.ts", "+++ b/apps/mobile/src/a.ts", "@@ -1,2 +1,3 @@", "-const before = 1;", "+const after = 2;", "+console.log(after);", " return true;", ].join("\n"), "unit", ); expect(parsed.kind).toBe("files"); if (parsed.kind !== "files") { return; } expect(parsed.fileCount).toBe(1); expect(parsed.additions).toBe(2); expect(parsed.deletions).toBe(1); expect(parsed.files[0]).toMatchObject({ path: "apps/mobile/src/a.ts", additions: 2, deletions: 1, }); expect(parsed.files[0]?.rows).toEqual([ expect.objectContaining({ kind: "hunk", header: "@@ -1,2 +1,3 @@" }), expect.objectContaining({ kind: "line", change: "delete", oldLineNumber: 1, newLineNumber: null, content: "const before = 1;", comparison: { change: "add", tokenIndex: 0 }, }), expect.objectContaining({ kind: "line", change: "add", oldLineNumber: null, newLineNumber: 1, content: "const after = 2;", comparison: { change: "delete", tokenIndex: 0 }, }), expect.objectContaining({ kind: "line", change: "add", oldLineNumber: null, newLineNumber: 2, content: "console.log(after);", comparison: null, }), expect.objectContaining({ kind: "line", change: "context", oldLineNumber: 2, newLineNumber: 3, content: "return true;", comparison: null, }), ]); }); it("treats truncated patches as partial diffs instead of failing", () => { const parsed = buildReviewParsedDiff( [ "diff --git a/apps/mobile/src/a.ts b/apps/mobile/src/a.ts", "index 1111111..2222222 100644", "--- a/apps/mobile/src/a.ts", "+++ b/apps/mobile/src/a.ts", "@@ -1 +1,2 @@", " const before = 1;", "+const after = 2;", "", "[truncated]", ].join("\n"), "unit-truncated", ); expect(parsed.kind).toBe("files"); if (parsed.kind !== "files") { return; } expect(parsed.notice).toContain("server size cap"); expect(parsed.fileCount).toBe(1); expect(parsed.files[0]?.rows[0]).toMatchObject({ kind: "hunk", header: "@@ -1,1 +1,2 @@", }); }); it("suppresses preview for non-text file formats", () => { const preview = getReviewFilePreviewState( makeRenderableFile({ path: "apps/mobile/assets/icon.png", }), ); expect(preview).toMatchObject({ kind: "suppressed", reason: "non-text", title: "Non-text file", actionLabel: null, }); }); it("suppresses large diffs until explicitly requested", () => { const preview = getReviewFilePreviewState( makeRenderableFile({ path: "apps/mobile/src/big.ts", rows: Array.from({ length: 401 }, (_, index) => ({ kind: "line" as const, id: `line-${index}`, change: "add" as const, oldLineNumber: null, newLineNumber: index + 1, content: `const line${index} = ${index};`, additionTokenIndex: index, deletionTokenIndex: null, comparison: null, })), }), ); expect(preview).toMatchObject({ kind: "suppressed", reason: "large", title: "Large diff", actionLabel: "Load diff", }); }); it("flattens expanded file rows into virtualized review items", () => { const file = makeRenderableFile({ path: "apps/mobile/src/a.ts", rows: [ { kind: "hunk", id: "hunk-1", header: "@@ -1,1 +1,2 @@", context: null, }, { kind: "line", id: "line-1", change: "add", oldLineNumber: null, newLineNumber: 1, content: "const after = 2;", additionTokenIndex: 0, deletionTokenIndex: null, comparison: null, }, ], }); const items = buildReviewListItems({ files: [file], expandedFileIds: [file.id], revealedLargeFileIds: [], }); expect(items).toEqual([ expect.objectContaining({ kind: "file-header", fileId: file.id, expanded: true }), expect.objectContaining({ kind: "hunk", fileId: file.id, file, row: file.rows[0], }), expect.objectContaining({ kind: "line", fileId: file.id, file, row: file.rows[1], lineIndex: 0, }), ]); }); it("keeps large diffs collapsed into a placeholder item until revealed", () => { const file = makeRenderableFile({ path: "apps/mobile/src/big.ts", rows: Array.from({ length: 401 }, (_, index) => ({ kind: "line" as const, id: `line-${index}`, change: "add" as const, oldLineNumber: null, newLineNumber: index + 1, content: `const line${index} = ${index};`, additionTokenIndex: index, deletionTokenIndex: null, comparison: null, })), }); const items = buildReviewListItems({ files: [file], expandedFileIds: [file.id], revealedLargeFileIds: [], }); expect(items).toEqual([ expect.objectContaining({ kind: "file-header", fileId: file.id, expanded: true }), expect.objectContaining({ kind: "file-suppressed", fileId: file.id, actionLabel: "Load diff", }), ]); });});
import { describe, expect, it } from "vitest";
import {
MessageId,
TurnId,
type OrchestrationCheckpointSummary,
type ReviewDiffPreviewSource,
} from "@t3tools/contracts";
import {
buildReviewListItems,
buildReviewParsedDiff,
buildReviewSectionItems,
getDefaultReviewSectionId,
getReviewFilePreviewState,
getReviewSectionIdForCheckpoint,
type ReviewRenderableFile,
} from "./reviewModel";
function makeCheckpoint(
input: Partial<OrchestrationCheckpointSummary> &
Pick<OrchestrationCheckpointSummary, "turnId" | "checkpointTurnCount" | "completedAt">,
): OrchestrationCheckpointSummary {
return {
checkpointRef: `refs/t3/checkpoints/thread/${input.checkpointTurnCount}` as any,
status: "ready",
files: [],
assistantMessageId: MessageId.make(`msg-${input.checkpointTurnCount}`),
...input,
};
}
function makeRenderableFile(
input: Partial<ReviewRenderableFile> & Pick<ReviewRenderableFile, "path">,
): ReviewRenderableFile {
return {
id: input.path,
cacheKey: input.path,
previousPath: null,
changeType: "new",
additions: 0,
deletions: 0,
languageHint: null,
additionLines: [],
deletionLines: [],
rows: [],
...input,
};
}
describe("buildReviewSectionItems", () => {
it("keeps one chip per checkpoint and appends git sources", () => {
const checkpoints = [
makeCheckpoint({
turnId: TurnId.make("turn-1"),
checkpointTurnCount: 1,
completedAt: "2026-04-01T00:00:00.000Z",
}),
makeCheckpoint({
turnId: TurnId.make("turn-2"),
checkpointTurnCount: 2,
completedAt: "2026-04-02T00:00:00.000Z",
}),
];
const gitSections: ReviewDiffPreviewSource[] = [
{
id: "working-tree",
kind: "working-tree",
title: "Dirty worktree",
baseRef: "HEAD",
headRef: null,
diff: "diff --git a/a.ts b/a.ts",
diffHash: "hash-dirty",
truncated: false,
},
{
id: "branch-range",
kind: "branch-range",
title: "Against main",
baseRef: "main",
headRef: "feature",
diff: "diff --git a/a.ts b/a.ts",
diffHash: "hash-base",
truncated: false,
},
];
const loadedTurnId = getReviewSectionIdForCheckpoint(checkpoints[0]);
const items = buildReviewSectionItems({
checkpoints,
gitSections,
turnDiffById: {
[loadedTurnId]: "diff --git a/loaded.ts b/loaded.ts",
},
loadingTurnIds: {
[getReviewSectionIdForCheckpoint(checkpoints[1])]: true,
},
loadingGitSections: false,
});
expect(items.map((item) => item.id)).toEqual([
"turn:2",
"turn:1",
"git:working-tree",
"git:branch-range",
]);
expect(items[0]).toMatchObject({ isLoading: true, diff: null });
expect(items[1]).toMatchObject({
isLoading: false,
diff: expect.stringContaining("loaded.ts"),
});
expect(getDefaultReviewSectionId(items)).toBe("turn:2");
});
it("shows dirty worktree while git preview is loading", () => {
const items = buildReviewSectionItems({
checkpoints: [],
gitSections: [],
turnDiffById: {},
loadingTurnIds: {},
loadingGitSections: true,
});
expect(items).toEqual([
expect.objectContaining({
id: "git:working-tree",
kind: "working-tree",
title: "Dirty worktree",
subtitle: "Tracked, staged, and untracked worktree changes",
diff: null,
isLoading: true,
}),
]);
expect(getDefaultReviewSectionId(items)).toBe("git:working-tree");
});
});
describe("buildReviewParsedDiff", () => {
it("builds renderable rows from a unified patch", () => {
const parsed = buildReviewParsedDiff(
[
"diff --git a/apps/mobile/src/a.ts b/apps/mobile/src/a.ts",
"index 1111111..2222222 100644",
"--- a/apps/mobile/src/a.ts",
"+++ b/apps/mobile/src/a.ts",
"@@ -1,2 +1,3 @@",
"-const before = 1;",
"+const after = 2;",
"+console.log(after);",
" return true;",
].join("\n"),
"unit",
);
expect(parsed.kind).toBe("files");
if (parsed.kind !== "files") {
return;
}
expect(parsed.fileCount).toBe(1);
expect(parsed.additions).toBe(2);
expect(parsed.deletions).toBe(1);
expect(parsed.files[0]).toMatchObject({
path: "apps/mobile/src/a.ts",
additions: 2,
deletions: 1,
});
expect(parsed.files[0]?.rows).toEqual([
expect.objectContaining({ kind: "hunk", header: "@@ -1,2 +1,3 @@" }),
expect.objectContaining({
kind: "line",
change: "delete",
oldLineNumber: 1,
newLineNumber: null,
content: "const before = 1;",
comparison: { change: "add", tokenIndex: 0 },
}),
expect.objectContaining({
kind: "line",
change: "add",
oldLineNumber: null,
newLineNumber: 1,
content: "const after = 2;",
comparison: { change: "delete", tokenIndex: 0 },
}),
expect.objectContaining({
kind: "line",
change: "add",
oldLineNumber: null,
newLineNumber: 2,
content: "console.log(after);",
comparison: null,
}),
expect.objectContaining({
kind: "line",
change: "context",
oldLineNumber: 2,
newLineNumber: 3,
content: "return true;",
comparison: null,
}),
]);
});
it("treats truncated patches as partial diffs instead of failing", () => {
const parsed = buildReviewParsedDiff(
[
"diff --git a/apps/mobile/src/a.ts b/apps/mobile/src/a.ts",
"index 1111111..2222222 100644",
"--- a/apps/mobile/src/a.ts",
"+++ b/apps/mobile/src/a.ts",
"@@ -1 +1,2 @@",
" const before = 1;",
"+const after = 2;",
"",
"[truncated]",
].join("\n"),
"unit-truncated",
);
expect(parsed.kind).toBe("files");
if (parsed.kind !== "files") {
return;
}
expect(parsed.notice).toContain("server size cap");
expect(parsed.fileCount).toBe(1);
expect(parsed.files[0]?.rows[0]).toMatchObject({
kind: "hunk",
header: "@@ -1,1 +1,2 @@",
});
});
it("suppresses preview for non-text file formats", () => {
const preview = getReviewFilePreviewState(
makeRenderableFile({
path: "apps/mobile/assets/icon.png",
}),
);
expect(preview).toMatchObject({
kind: "suppressed",
reason: "non-text",
title: "Non-text file",
actionLabel: null,
});
});
it("suppresses large diffs until explicitly requested", () => {
const preview = getReviewFilePreviewState(
makeRenderableFile({
path: "apps/mobile/src/big.ts",
rows: Array.from({ length: 401 }, (_, index) => ({
kind: "line" as const,
id: `line-${index}`,
change: "add" as const,
oldLineNumber: null,
newLineNumber: index + 1,
content: `const line${index} = ${index};`,
additionTokenIndex: index,
deletionTokenIndex: null,
comparison: null,
})),
}),
);
expect(preview).toMatchObject({
kind: "suppressed",
reason: "large",
title: "Large diff",
actionLabel: "Load diff",
});
});
it("flattens expanded file rows into virtualized review items", () => {
const file = makeRenderableFile({
path: "apps/mobile/src/a.ts",
rows: [
{
kind: "hunk",
id: "hunk-1",
header: "@@ -1,1 +1,2 @@",
context: null,
},
{
kind: "line",
id: "line-1",
change: "add",
oldLineNumber: null,
newLineNumber: 1,
content: "const after = 2;",
additionTokenIndex: 0,
deletionTokenIndex: null,
comparison: null,
},
],
});
const items = buildReviewListItems({
files: [file],
expandedFileIds: [file.id],
revealedLargeFileIds: [],
});
expect(items).toEqual([
expect.objectContaining({ kind: "file-header", fileId: file.id, expanded: true }),
expect.objectContaining({
kind: "hunk",
fileId: file.id,
file,
row: file.rows[0],
}),
expect.objectContaining({
kind: "line",
fileId: file.id,
file,
row: file.rows[1],
lineIndex: 0,
}),
]);
});
it("keeps large diffs collapsed into a placeholder item until revealed", () => {
const file = makeRenderableFile({
path: "apps/mobile/src/big.ts",
rows: Array.from({ length: 401 }, (_, index) => ({
kind: "line" as const,
id: `line-${index}`,
change: "add" as const,
oldLineNumber: null,
newLineNumber: index + 1,
content: `const line${index} = ${index};`,
additionTokenIndex: index,
deletionTokenIndex: null,
comparison: null,
})),
});
const items = buildReviewListItems({
files: [file],
expandedFileIds: [file.id],
revealedLargeFileIds: [],
});
expect(items).toEqual([
expect.objectContaining({ kind: "file-header", fileId: file.id, expanded: true }),
expect.objectContaining({
kind: "file-suppressed",
fileId: file.id,
actionLabel: "Load diff",
}),
]);
});
});