Unify perf toggle fallback logic across config helpers

Cursor Agent committed 9 months ago

Commit 7aff63f1 parent 0a733fe2 files · +24 −9Browse files

Unified · Split

2 files

apps/desktop/src/perfConfig.test.ts +15 −0
apps/desktop/src/perfConfig.ts +9 −9

apps/desktop/src/perfConfig.test.ts+15−0

@@ -207,6 +207,21 @@ describe("shouldRunOptionalRendererPerfInteractions", () => { · 206 unmodified lines
207	207	}),
208	208	).toBe(false);
209	209	});
	210	+
	211	+ it("falls back to CI default for unknown values", () => {
	212	+ expect(
	213	+ shouldRunOptionalRendererPerfInteractions({
	214	+ T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER: "maybe",
	215	+ CI: "true",
	216	+ }),
	217	+ ).toBe(false);
	218	+ expect(
	219	+ shouldRunOptionalRendererPerfInteractions({
	220	+ T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER: "maybe",
	221	+ CI: "false",
	222	+ }),
	223	+ ).toBe(true);
	224	+ });
210	225	});
211	226
212	227	describe("shouldRunBenchmarkThreadSweep", () => {

apps/desktop/src/perfConfig.ts+9−9

@@ -34,6 +34,12 @@ function isCiEnvironment(value: string \| undefined): boolean { · 33 unmodified lines
34	34	return parseBooleanLike(value) === true;
35	35	}
36	36
	37	+function resolveBooleanToggle(rawValue: string \| undefined, ciValue: string \| undefined): boolean {
	38	+ const toggleOverride = parseBooleanLike(rawValue);
	39	+ if (toggleOverride !== null) return toggleOverride;
	40	+ return !isCiEnvironment(ciValue);
	41	+}
	42	+
37	43	/**
38	44	* Controls whether desktop perf automation should include terminal shortcuts.
39	45	*
@@ -46,21 +52,15 @@ function isCiEnvironment(value: string \| undefined): boolean { · 6 unmodified lines
46	52	* flaky PTY-dependent interactions in ephemeral Linux runners.
47	53	*/
48	54	export function shouldRunTerminalPerfInteractions(env: PerfToggleEnv): boolean {
49		− const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_TERMINAL);
50		− if (toggleOverride !== null) return toggleOverride;
51		− return !isCiEnvironment(env.CI);
	55	+ return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_TERMINAL, env.CI);
52	56	}
53	57
54	58	export function shouldRunOptionalRendererPerfInteractions(env: OptionalRendererToggleEnv): boolean {
55		− const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER);
56		− if (toggleOverride !== null) return toggleOverride;
57		− return !isCiEnvironment(env.CI);
	59	+ return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER, env.CI);
58	60	}
59	61
60	62	export function shouldRunBenchmarkThreadSweep(env: BenchmarkSweepToggleEnv): boolean {
61		− const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_BENCHMARK_SWEEP);
62		− if (toggleOverride !== null) return toggleOverride;
63		− return !isCiEnvironment(env.CI);
	63	+ return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_BENCHMARK_SWEEP, env.CI);
64	64	}
65	65
66	66	export function resolveBenchmarkFollowUpPassCount(env: PerfBenchmarkEnv): number {

Unify perf toggle fallback logic across config helpers

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code