remove restriction in MidiOut on message size; thanks mariobuoninfante for the fix

Ge Wang committed 5 years ago

Commit 2bfcc0d1 parent 96265323 files · +14 −5Browse files

Unified · Split

3 files

notes/VERSIONS +5 −0
src/core/midiio_rtmidi.cpp +3 −0
src/core/rtmidi.cpp +6 −5

notes/VERSIONS+5−0

@@ -50,6 +50,11 @@ · 49 unmodified lines
50	50	mariobuoninfante for help in addressing this)
51	51	- (fixed) reset Gen10 table to allow add/remove partials; thanks to
52	52	mariobuoninfant
	53	+ - (fixed) updated MidiOut and removed check in order to allow messages
	54	+ of size less than or greater than 3 bytes; thanks to mariobuoninfante
	55	+ for this issue report on Ubuntu Studio 64-bit; this fix addresses
	56	+ the sending of MIDI clock, stop, continue, and SysEx -- also thank
	57	+ you mariobuoninfante for the fix.
53	58	- (deprecated) Chubgraph => (new) Chugraph;
54	59	Chubgraph will continue to function, with a deprecation warning.
55	60	- (documentation) updated embedded documentation text for all statically

src/core/midiio_rtmidi.cpp+3−0

@@ -402,6 +402,9 @@ t_CKBOOL MidiInManager::open( MidiIn * min, Chuck_VM * vm, t_CKINT device_num ) · 401 unmodified lines
402	402	return FALSE;
403	403	}
404	404
	405	+ // clear ignore types \| 1.4.0.2 (mariobuoninfante)
	406	+ rtmin->ignoreTypes( false, false, false );
	407	+
405	408	// resize?
406	409	if( device_num >= (t_CKINT)the_mins.capacity() )
407	410	{

src/core/rtmidi.cpp+6−5

@@ -1418,11 +1418,12 @@ void RtMidiOut :: sendMessage( std::vector<unsigned char> *message ) · 1417 unmodified lines
1418	1418	snd_seq_ev_set_direct(&ev);
1419	1419	for ( unsigned int i=0; i<nBytes; i++ ) data->buffer[i] = message->at(i);
1420	1420	result = snd_midi_event_encode( data->coder, data->buffer, (long)nBytes, &ev );
1421		− if ( result < (int)nBytes ) {
1422		− errorString_ = "RtMidiOut::sendMessage: event parsing error!";
1423		− error( RtMidiError::WARNING );
1424		− return;
1425		− }
	1421	+ // commenting this out allows sending MIDI messages < and > 3 \| 1.4.0.2 (mariobuoninfante)
	1422	+ // if( result < (int)nBytes ) {
	1423	+ // errorString_ = "RtMidiOut::sendMessage: event parsing error!";
	1424	+ // error( RtMidiError::WARNING );
	1425	+ // return;
	1426	+ // }
1426	1427
1427	1428	// Send the event.
1428	1429	result = snd_seq_event_output(data->seq, &ev);