History

Fix mips dspr2 idct4x4 functions for large coefficient input

Kaustubh Raste committed 9 years ago

Commit afd2d791 parent c7e2bd61 file · +61 −26Browse files

Unified · Split

vpx_dsp/mips/itrans4_dspr2.c+61−26
@@ -15,7 +15,7 @@ · 14 unmodified lines
1515
1616 #if HAVE_DSPR2
1717 void vpx_idct4_rows_dspr2(const int16_t *input, int16_t *output) {
18− int16_t step_0, step_1, step_2, step_3;
18+ int step_0, step_1, step_2, step_3;
1919 int Temp0, Temp1, Temp2, Temp3;
2020 const int const_2_power_13 = 8192;
2121 int i;
@@ -97,22 +97,12 @@ void vpx_idct4_rows_dspr2(const int16_t *input, int16_t *output) { · 75 unmodified lines
9797
9898 void vpx_idct4_columns_add_blk_dspr2(int16_t *input, uint8_t *dest,
9999 int stride) {
100− int16_t step_0, step_1, step_2, step_3;
100+ int step_0, step_1, step_2, step_3;
101101 int Temp0, Temp1, Temp2, Temp3;
102102 const int const_2_power_13 = 8192;
103+ const int const_255 = 255;
103104 int i;
104105 uint8_t *dest_pix;
105− uint8_t *cm = vpx_ff_cropTbl;
106−
107− /* prefetch vpx_ff_cropTbl */
108− prefetch_load(vpx_ff_cropTbl);
109− prefetch_load(vpx_ff_cropTbl + 32);
110− prefetch_load(vpx_ff_cropTbl + 64);
111− prefetch_load(vpx_ff_cropTbl + 96);
112− prefetch_load(vpx_ff_cropTbl + 128);
113− prefetch_load(vpx_ff_cropTbl + 160);
114− prefetch_load(vpx_ff_cropTbl + 192);
115− prefetch_load(vpx_ff_cropTbl + 224);
116106
117107 for (i = 0; i < 4; ++i) {
118108 dest_pix = (dest + i);
@@ -172,43 +162,55 @@ void vpx_idct4_columns_add_blk_dspr2(int16_t *input, uint8_t *dest, · 53 unmodified lines
172162 "sra %[Temp0], %[Temp0], 4 \n\t"
173163 "lbu %[Temp1], 0(%[dest_pix]) \n\t"
174164 "add %[Temp1], %[Temp1], %[Temp0] \n\t"
175− "add %[Temp0], %[step_1], %[step_2] \n\t"
176− "lbux %[Temp2], %[Temp1](%[cm]) \n\t"
177− "sb %[Temp2], 0(%[dest_pix]) \n\t"
165+ "slt %[Temp2], %[Temp1], %[const_255] \n\t"
166+ "slt %[Temp3], $zero, %[Temp1] \n\t"
167+ "movz %[Temp1], %[const_255], %[Temp2] \n\t"
168+ "movz %[Temp1], $zero, %[Temp3] \n\t"
169+ "sb %[Temp1], 0(%[dest_pix]) \n\t"
178170 "addu %[dest_pix], %[dest_pix], %[stride] \n\t"
179171
172+ "add %[Temp0], %[step_1], %[step_2] \n\t"
180173 "addi %[Temp0], %[Temp0], 8 \n\t"
181174 "sra %[Temp0], %[Temp0], 4 \n\t"
182175 "lbu %[Temp1], 0(%[dest_pix]) \n\t"
183176 "add %[Temp1], %[Temp1], %[Temp0] \n\t"
184− "sub %[Temp0], %[step_1], %[step_2] \n\t"
185− "lbux %[Temp2], %[Temp1](%[cm]) \n\t"
186− "sb %[Temp2], 0(%[dest_pix]) \n\t"
177+ "slt %[Temp2], %[Temp1], %[const_255] \n\t"
178+ "slt %[Temp3], $zero, %[Temp1] \n\t"
179+ "movz %[Temp1], %[const_255], %[Temp2] \n\t"
180+ "movz %[Temp1], $zero, %[Temp3] \n\t"
181+ "sb %[Temp1], 0(%[dest_pix]) \n\t"
187182 "addu %[dest_pix], %[dest_pix], %[stride] \n\t"
188183
184+ "sub %[Temp0], %[step_1], %[step_2] \n\t"
189185 "addi %[Temp0], %[Temp0], 8 \n\t"
190186 "sra %[Temp0], %[Temp0], 4 \n\t"
191187 "lbu %[Temp1], 0(%[dest_pix]) \n\t"
192188 "add %[Temp1], %[Temp1], %[Temp0] \n\t"
193− "sub %[Temp0], %[step_0], %[step_3] \n\t"
194− "lbux %[Temp2], %[Temp1](%[cm]) \n\t"
195− "sb %[Temp2], 0(%[dest_pix]) \n\t"
189+ "slt %[Temp2], %[Temp1], %[const_255] \n\t"
190+ "slt %[Temp3], $zero, %[Temp1] \n\t"
191+ "movz %[Temp1], %[const_255], %[Temp2] \n\t"
192+ "movz %[Temp1], $zero, %[Temp3] \n\t"
193+ "sb %[Temp1], 0(%[dest_pix]) \n\t"
196194 "addu %[dest_pix], %[dest_pix], %[stride] \n\t"
197195
196+ "sub %[Temp0], %[step_0], %[step_3] \n\t"
198197 "addi %[Temp0], %[Temp0], 8 \n\t"
199198 "sra %[Temp0], %[Temp0], 4 \n\t"
200199 "lbu %[Temp1], 0(%[dest_pix]) \n\t"
201200 "add %[Temp1], %[Temp1], %[Temp0] \n\t"
202− "lbux %[Temp2], %[Temp1](%[cm]) \n\t"
203− "sb %[Temp2], 0(%[dest_pix]) \n\t"
201+ "slt %[Temp2], %[Temp1], %[const_255] \n\t"
202+ "slt %[Temp3], $zero, %[Temp1] \n\t"
203+ "movz %[Temp1], %[const_255], %[Temp2] \n\t"
204+ "movz %[Temp1], $zero, %[Temp3] \n\t"
205+ "sb %[Temp1], 0(%[dest_pix]) \n\t"
204206
205207 : [Temp0] "=&r"(Temp0), [Temp1] "=&r"(Temp1), [Temp2] "=&r"(Temp2),
206208 [Temp3] "=&r"(Temp3), [step_0] "=&r"(step_0), [step_1] "=&r"(step_1),
207209 [step_2] "=&r"(step_2), [step_3] "=&r"(step_3),
208210 [dest_pix] "+r"(dest_pix)
209− : [const_2_power_13] "r"(const_2_power_13),
211+ : [const_2_power_13] "r"(const_2_power_13), [const_255] "r"(const_255),
210212 [cospi_8_64] "r"(cospi_8_64), [cospi_16_64] "r"(cospi_16_64),
211− [cospi_24_64] "r"(cospi_24_64), [input] "r"(input), [cm] "r"(cm),
213+ [cospi_24_64] "r"(cospi_24_64), [input] "r"(input),
212214 [stride] "r"(stride));
213215
214216 input += 4;
@@ -274,6 +276,39 @@ void vpx_idct4x4_1_add_dspr2(const int16_t *input, uint8_t *dest, int stride) { · 59 unmodified lines
274276 : [t2] "=&r"(t2), [vector_a] "=&r"(vector_a), [dest] "+&r"(dest)
275277 : [stride] "r"(stride), [vector_a1] "r"(vector_a1));
276278 }
279+ } else if (a1 > 255) {
280+ int32_t a11, a12, vector_a11, vector_a12;
281+
282+ /* use quad-byte
283+ * input and output memory are four byte aligned */
284+ a11 = a1 >> 3;
285+ a12 = a1 - (a11 * 7);
286+
287+ __asm__ __volatile__(
288+ "replv.qb %[vector_a11], %[a11] \n\t"
289+ "replv.qb %[vector_a12], %[a12] \n\t"
290+
291+ : [vector_a11] "=&r"(vector_a11), [vector_a12] "=&r"(vector_a12)
292+ : [a11] "r"(a11), [a12] "r"(a12));
293+
294+ for (r = 4; r--;) {
295+ __asm__ __volatile__(
296+ "lw %[t2], 4(%[dest]) \n\t"
297+ "addu_s.qb %[vector_a], %[t2], %[vector_a11] \n\t"
298+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
299+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
300+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
301+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
302+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
303+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a11] \n\t"
304+ "addu_s.qb %[vector_a], %[vector_a], %[vector_a12] \n\t"
305+ "sw %[vector_a], 0(%[dest]) \n\t"
306+ "add %[dest], %[dest], %[stride] \n\t"
307+
308+ : [t2] "=&r"(t2), [vector_a] "=&r"(vector_a), [dest] "+&r"(dest)
309+ : [stride] "r"(stride), [vector_a11] "r"(vector_a11),
310+ [vector_a12] "r"(vector_a12));
311+ }
277312 } else {
278313 /* use quad-byte
279314 * input and output memory are four byte aligned */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t